From owner-svn-src-head@FreeBSD.ORG Mon Jan 26 23:05:50 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6F84410656BA; Mon, 26 Jan 2009 23:05:50 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 5E9558FC1A; Mon, 26 Jan 2009 23:05:50 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n0QN5ojc065680; Mon, 26 Jan 2009 23:05:50 GMT (envelope-from sam@svn.freebsd.org) Received: (from sam@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n0QN5ovS065679; Mon, 26 Jan 2009 23:05:50 GMT (envelope-from sam@svn.freebsd.org) Message-Id: <200901262305.n0QN5ovS065679@svn.freebsd.org> From: Sam Leffler Date: Mon, 26 Jan 2009 23:05:50 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r187743 - head/etc X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jan 2009 23:05:51 -0000 Author: sam Date: Mon Jan 26 23:05:50 2009 New Revision: 187743 URL: http://svn.freebsd.org/changeset/base/187743 Log: Remove DETACH event handling; this is race prone and does nothing useful. Leave a comment for the next person that thinks they need to be helpful. Reviewed by: imp, jhb MFC after: 2 weeks Modified: head/etc/devd.conf Modified: head/etc/devd.conf ============================================================================== --- head/etc/devd.conf Mon Jan 26 21:45:33 2009 (r187742) +++ head/etc/devd.conf Mon Jan 26 23:05:50 2009 (r187743) @@ -31,18 +31,17 @@ options { # Configure the interface on attach. Due to a historical accident, this # script is called pccard_ether. # +# NB: DETACH events are ignored; the kernel should handle all cleanup +# (routes, arp cache) if you need to do something beware of races +# against immediate create of a device w/ the same name; e.g. +# ifconfig bridge0 destroy; ifconfig bridge0 create +# notify 0 { match "system" "IFNET"; match "type" "ATTACH"; action "/etc/pccard_ether $subsystem start"; }; -notify 0 { - match "system" "IFNET"; - match "type" "DETACH"; - action "/etc/pccard_ether $subsystem stop"; -}; - # # Try to start dhclient on Ethernet like interfaces when the link comes # up. Only devices that are configured to support DHCP will actually