From owner-freebsd-hackers@FreeBSD.ORG Mon Jul 16 12:01:00 2012 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0301F1065904; Mon, 16 Jul 2012 12:01:00 +0000 (UTC) (envelope-from ae@FreeBSD.org) Received: from mail.kirov.so-ups.ru (ns.kirov.so-ups.ru [178.74.170.1]) by mx1.freebsd.org (Postfix) with ESMTP id 986958FC1D; Mon, 16 Jul 2012 12:00:59 +0000 (UTC) Received: from kas30pipe.localhost (localhost.kirov.so-ups.ru [127.0.0.1]) by mail.kirov.so-ups.ru (Postfix) with SMTP id 2D320B8027; Mon, 16 Jul 2012 16:00:54 +0400 (MSK) Received: from kirov.so-ups.ru (unknown [172.21.81.1]) by mail.kirov.so-ups.ru (Postfix) with ESMTP id 27696B8024; Mon, 16 Jul 2012 16:00:54 +0400 (MSK) Received: by ns.kirov.so-ups.ru (Postfix, from userid 1010) id 20EEABA083; Mon, 16 Jul 2012 16:00:54 +0400 (MSK) Received: from [127.0.0.1] (unknown [10.118.3.52]) by ns.kirov.so-ups.ru (Postfix) with ESMTP id DE091BA07C; Mon, 16 Jul 2012 16:00:53 +0400 (MSK) Message-ID: <50040271.5000301@FreeBSD.org> Date: Mon, 16 Jul 2012 16:00:49 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla Thunderbird 1.5 (FreeBSD/20051231) MIME-Version: 1.0 To: Andriy Gapon References: <4FE9B01C.30306@yandex.ru> <5003EBAB.6030507@FreeBSD.org> <5003F39D.6030808@FreeBSD.org> <5003F589.40603@FreeBSD.org> <5003F79E.1060706@FreeBSD.org> <5003FB9D.90909@FreeBSD.org> In-Reply-To: <5003FB9D.90909@FreeBSD.org> X-Enigmail-Version: 1.4.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig09929B86E2E15E68F7B5E8F9" X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0284], KAS30/Release X-SpamTest-Info: Not protected Cc: freebsd-hackers , Marius Strobl , freebsd-current , Pawel Jakub Dawidek Subject: Re: [CFC/CFT] large changes in the loader(8) code X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2012 12:01:00 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig09929B86E2E15E68F7B5E8F9 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On 16.07.2012 15:31, Andriy Gapon wrote: >> Yes. It should work as before. >=20 > Well, but it's obvious that zfs_probe_dev would be attempting to do som= e unneeded > stuff (trying to treat partitions as disks) for that case. To me this = is a clear > indication zfs_probe_dev is not optimal for arch-independent implementa= tion. So I > still think that arch_zfs_probe should decide what disks and partitions= to probe, > and zfs_probe_dev should only probe what it's given and not try to be a= ny smarter. > But I've repeated myself three times already :-) And we will have the same - several copies of the same code in each archi= tecture, which i have deleted... Sparc doesn't support DIOCGMEDIASIZE and DIOCGSECTORSIZE ioctls, so it will not check each partition, only fd that is passed to the zfs_pr= obe_dev. Currently there is only one problem with ZFS tasting, that can affect use= rs - now we taste each disk and partition, but in the my branch ZFS tastes onl= y disks and partitions with type "freebsd" and "freebsd-zfs". So if you have created = ZFS on top of MBR partition with type "ntfs", then loader will be unable to detect i= t. --=20 WBR, Andrey V. Elsukov --------------enig09929B86E2E15E68F7B5E8F9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJQBAJ1AAoJEAHF6gQQyKF6oxQH/1StRDHfuQD3PzWQZUcraIni meEi0RN+XneeWY6dJi0A4182cW9uP+sDXkClAYViUEBBjkYgq7bEpZ0sGbengiz/ U+jLooGgYS0K1KalIXkP4nke87OqVKeCr1cwat4fyUg0g1QOTHs9LF77HkQq3AgS Blzz4CHR7/J+nyhp6HIRF19zoIhiZKDMcfOEPjDsC4OrWynnsNR6GMJ1gFxpl/WH RVfMYW9/sux4ggB53HN9pm6+abOOtHFat34FX7nruooBLZJd+JdC8oEUlrWIPgIf 43j7irsAraj/+iQ75KrzKPSUr9i69Mk+mOylA3q7DThZKUjGDAVm70ojSsDl41w= =X6bX -----END PGP SIGNATURE----- --------------enig09929B86E2E15E68F7B5E8F9--