From owner-freebsd-net Tue Jun 12 13:24:22 2001 Delivered-To: freebsd-net@freebsd.org Received: from smtp1.oskarmobil.cz (smtp1.oskarmobil.cz [217.77.161.133]) by hub.freebsd.org (Postfix) with ESMTP id 6CDEF37B408 for ; Tue, 12 Jun 2001 13:24:11 -0700 (PDT) (envelope-from Milon.Papezik@oskarmobil.cz) Received: from wh01ex02.ceskymobil.cz (wh01ex02.ceskymobil.cz [172.20.128.42]) by smtp1.oskarmobil.cz (8.11.2/8.11.1) with ESMTP id f5CKKRE04564; Tue, 12 Jun 2001 22:20:27 +0200 (CEST) (envelope-from Milon.Papezik@oskarmobil.cz) Received: by wh01ex02.ceskymobil.cz with Internet Mail Service (5.5.2653.19) id ; Tue, 12 Jun 2001 22:23:58 +0200 Message-ID: <11CCE9D433CFD311B32A00508B95BCA005E4A2D1@wh01ex02.ceskymobil.cz> From: Milon Papezik To: "'freebsd-hackers@freebsd.net'" , "'freebsd-net@freebsd.org'" Subject: Netgraph ng_fec module (from wpaul) Date: Tue, 12 Jun 2001 22:23:50 +0200 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2653.19) Content-Type: text/plain; charset="ISO-8859-2" Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Hi all, I tested the ng_fec module from http://www.freebsd.org/~wpaul/FEC and I think I found an error in implementation from 4.x. There is a difference between 4.x and 5.x version of netgraph/ng_fec.c at line 313(312) in manipulation with reffernce counts: 313c312 < ng_units_in_use++; --- > ng_units_in_use--; Could someone please try comment what is correct (5.x seems to be right) ? Also could this be possible cause of panics when one of the underlaying interfaces was shut down using 'ifconfig fxp0 down' ? (it seems to work after change to decrement in 4.x version). Thanks in advance, Milon -- milon.papezik@oskarmobil.cz To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message