From owner-freebsd-bugs Tue Feb 28 18:07:11 1995 Return-Path: bugs-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.9/8.6.6) id SAA28951 for bugs-outgoing; Tue, 28 Feb 1995 18:07:11 -0800 Received: from feta.cisco.com (feta.cisco.com [171.69.1.158]) by freefall.cdrom.com (8.6.9/8.6.6) with ESMTP id SAA28945 for ; Tue, 28 Feb 1995 18:07:09 -0800 Received: from localhost.cisco.com (localhost.cisco.com [127.0.0.1]) by feta.cisco.com (8.6.8+c/CISCO.SERVER.1.1) with SMTP id SAA25759; Tue, 28 Feb 1995 18:06:32 -0800 Message-Id: <199503010206.SAA25759@feta.cisco.com> X-Authentication-Warning: feta.cisco.com: Host localhost.cisco.com didn't use HELO protocol To: "Andrey A. Chernov, Black Mage" Cc: bugs@FreeBSD.org, Serg Vakulenko Subject: Re: do not implement misc/186 In-Reply-To: Your message of "Wed, 01 Mar 1995 05:02:51 +0300." Date: Tue, 28 Feb 1995 18:06:32 -0800 From: Paul Traina Sender: bugs-owner@FreeBSD.org Precedence: bulk Oh damn. From: "Andrey A. Chernov, Black Mage" Subject: Re: do not implement misc/186 In message <199503010056.QAA21722@feta.cisco.com> Paul Traina writes: >Subject: Re: misc/186: Sendmail incorrectly defines $s macro inside the rule >> #0 This fix already applied long time ago to our sources and you restore it after merging deliver.c changes. >------- Forwarded Message >Date: Tue, 28 Feb 1995 16:33:28 -0800 >From: Eric Allman >To: Paul Traina >cc: sendmail@cs.Berkeley.EDU >Subject: Re: misc/186: Sendmail incorrectly defines $s macro inside the rule >> #0 >I don't believe that is correct fix, since host isn't necessarily >meaningful at that point (e.g., for local mail), and CurHostName >is used for more than setting $s. The 8.7 code has that as just >setting CurHostName = NULL at that point -- you'll notice that it >gets reset later in the code if there is a valid host name. Right, it isn't meaningful just in _that_ point, but becomes meaningful later, so setting it to junk value not helps at all. Just look down into code, it resets later in some places, but not in _all_ cases. What happens if it isn't reset? I can answer: in this case it triggers a bug, since have junk value instead of host value. -- Andrey A. Chernov : And I rest so composedly, /Now, in my bed, ache@astral.msk.su : That any beholder /Might fancy me dead - FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead. RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849