From owner-cvs-src@FreeBSD.ORG Mon Feb 28 10:25:07 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4439416A4CE; Mon, 28 Feb 2005 10:25:07 +0000 (GMT) Received: from relay.bestcom.ru (relay.bestcom.ru [217.72.144.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4CC0143D3F; Mon, 28 Feb 2005 10:25:06 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (root@cell.sick.ru [217.72.144.68]) by relay.bestcom.ru (8.13.1/8.12.9) with ESMTP id j1SAP4Bw050761 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 28 Feb 2005 13:25:05 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.1/8.12.8) with ESMTP id j1SAP3MC066600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 28 Feb 2005 13:25:04 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.1/8.13.1/Submit) id j1SAP3Hx066599; Mon, 28 Feb 2005 13:25:03 +0300 (MSK) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Mon, 28 Feb 2005 13:25:03 +0300 From: Gleb Smirnoff To: "Matthew N. Dodd" , sos@freebsd.org Message-ID: <20050228102503.GB66092@cell.sick.ru> References: <200502272035.j1RKZNO7031606@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200502272035.j1RKZNO7031606@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: ClamAV version devel-20050125, clamav-milter version 0.80ff on relay.bestcom.ru X-Virus-Status: Clean cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/ata ata-all.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2005 10:25:07 -0000 Matthew, Soren, On Sun, Feb 27, 2005 at 08:35:23PM +0000, Matthew N. Dodd wrote: M> mdodd 2005-02-27 20:35:23 UTC M> M> FreeBSD src repository M> M> Modified files: (Branch: RELENG_5) M> sys/dev/ata ata-all.c M> Log: M> MFC: 1.235 M> M> Avoid using tsleep() in the resume path as it may result in the M> system hanging if timer interrupts aren't running yet. M> M> This allows my Thinkpad to resume successfully with APM. We also need to MFC 1.233, because it fixes broken suspend. revision 1.233 date: 2004/10/19 20:13:38; author: sos; state: Exp; lines: +10 -10 Idle the channel earlier in reinit(). Cosmetic change to suspend, dont call tsleep an extra time at exit. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE