From owner-freebsd-hackers@FreeBSD.ORG  Fri Aug  4 15:48:52 2006
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5A03F16A4DF
	for <freebsd-hackers@freebsd.org>; Fri,  4 Aug 2006 15:48:52 +0000 (UTC)
	(envelope-from joao.barros@gmail.com)
Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2F96343D45
	for <freebsd-hackers@freebsd.org>; Fri,  4 Aug 2006 15:48:50 +0000 (GMT)
	(envelope-from joao.barros@gmail.com)
Received: by wx-out-0506.google.com with SMTP id i27so115270wxd
	for <freebsd-hackers@freebsd.org>; Fri, 04 Aug 2006 08:48:50 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=FIHRG0O/tmN5EcJGMbbWgwM+3DIVhfLro+0iU75t0gpDCrVoxdV8DywmhZ88EPVNCK7TtuZnEjLITfVidnmY3daQRGWGUiT546kSbANX/xiYUG2s0A303VaThRgHMH8PgchLlJHcE1UFxQq3bxSdlsVNmNCNJ4c2VXF7wrP34lM=
Received: by 10.70.67.2 with SMTP id p2mr2841182wxa;
	Fri, 04 Aug 2006 08:48:50 -0700 (PDT)
Received: by 10.35.112.18 with HTTP; Fri, 4 Aug 2006 08:48:49 -0700 (PDT)
Message-ID: <70e8236f0608040848x304a671cle6d490f43735737b@mail.gmail.com>
Date: Fri, 4 Aug 2006 16:48:49 +0100
From: "Joao Barros" <joao.barros@gmail.com>
To: "Gleb Smirnoff" <glebius@freebsd.org>
In-Reply-To: <20060804150302.GD96644@cell.sick.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <70e8236f0608030735m519d880fgebeca7108b859244@mail.gmail.com>
	<20060804150302.GD96644@cell.sick.ru>
Cc: freebsd-hackers@freebsd.org
Subject: Re: [PATCH] add header "pppoe:" in ng_pppoe.c printfs
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Aug 2006 15:48:52 -0000

On 8/4/06, Gleb Smirnoff <glebius@freebsd.org> wrote:
> On Thu, Aug 03, 2006 at 03:35:04PM +0100, Joao Barros wrote:
> J> Being this a cryptic message to say the least and to probably save
> J> someone some time when presented with this message I attach a patch
> J> that adds the header "pppoe:" in every printf that didn't have it,
> J> making it consistent with the rest of the file.
>
> I've attached a patch that cleans a bit logging in ng_pppoe. It changes
> all printf(9) to log(9). The latter is better since it spams console
> less, if event occurs many times per second. Also I've made the messages
> more clear - prepended node ID where possible, function name when it
> starts with ng_pppoe, or just "ng_pppoe".
>
> Can you please try out this patch and tell whether you like it. If you
> do I will commit it soon.

Hi,

I've looked at the patch and it looks ok.
It serves the purpose: make the messages more clear with the added
bonus of more info.
Thanks for taking the time to look into this :-)

-- 
Joao Barros