From owner-cvs-src@FreeBSD.ORG Sun Feb 10 12:49:06 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E2B616A418 for ; Sun, 10 Feb 2008 12:49:06 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.156]) by mx1.freebsd.org (Postfix) with ESMTP id 63BFA13C442 for ; Sun, 10 Feb 2008 12:49:05 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by fg-out-1718.google.com with SMTP id 16so3669770fgg.35 for ; Sun, 10 Feb 2008 04:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=Xhe/CWYHKXQFG8JIfrKh45/hfK/yePXZgdGXGgd5sUc=; b=Tmg61jZz+LuAT3C7KaAW9FqFRRqDBOBOmGztzlxrQTY5PiAK2mz9dZ820/pP5mhZVqhyTE0qky+7iYw5os1ZqREBA12umHGqRzq4UHjs0uB2nAHNimHsR0N1ru+9eyHOI1h3Q0mLWh8DmD3D1AbXIMpNI66U6+bDGxxQ9PXV5f8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=ITA3KY/wPUGD2xtVISRDntRxoaVWoL/4vLXRgJc24xD/xJR0yzJmEWV5QFCjmU/ByWpfF++qblUpvp4DZAbv71ZB8LeEvU3KC2mjPghfqPYk5Cl41NL+pneQk82H69L/RAs3akyR8h5bs40391vBVxlv8fCDzBlXG9T56yMe8Yo= Received: by 10.86.51.2 with SMTP id y2mr9004529fgy.50.1202647744014; Sun, 10 Feb 2008 04:49:04 -0800 (PST) Received: by 10.86.30.17 with HTTP; Sun, 10 Feb 2008 04:49:04 -0800 (PST) Message-ID: <3bbf2fe10802100449r1b673bbfl3e41a419b08c0@mail.gmail.com> Date: Sun, 10 Feb 2008 13:49:04 +0100 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Robert Watson" In-Reply-To: <20080210120359.A97821@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200802092137.m19Lbsiu098036@repoman.freebsd.org> <20080210113949.GN57756@deviant.kiev.zoral.com.ua> <20080210120359.A97821@fledge.watson.org> X-Google-Sender-Auth: f1a15696c2ea7332 Cc: Kostik Belousov , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys lockmgr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Feb 2008 12:49:06 -0000 2008/2/10, Robert Watson : > > On Sun, 10 Feb 2008, Kostik Belousov wrote: > > > On Sat, Feb 09, 2008 at 09:37:54PM +0000, Attilio Rao wrote: > >> attilio 2008-02-09 21:37:54 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/sys lockmgr.h > >> Log: > >> Use LOCK_FILE and LOCK_LINE where necessary instead than __FILE__ and > >> __LINE__ with lockmgr. > >> > >> Revision Changes Path > >> 1.60 +2 -2 src/sys/sys/lockmgr.h > > > > I think this shall be MFCed to RELENG_7 and RELENG_7_0. > > > ... once it no longer breaks the tinderbox? > > BTW, at this point 7.0 is basically closed to any further changes. Anyone > planning on getting things in to 7.x needs to be thinking about either errata > notices (for really critical things) and 7.1. Buh! I'm very sorry for this. Really, this needed to be better croaked. It needs to include sys/lock.h for any lockmgr.h consumer (making lock.h a pre-requirement in lockmgr usage). This is going to be a little bit of work. For the moment I will revert this change, doing a better stub later, once other details about lockmgr are refined. Thanks, Attilio (pointy hat on) -- Peace can only be achieved by understanding - A. Einstein