From owner-svn-src-head@freebsd.org Thu Dec 17 10:07:55 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 823A54B2A5B; Thu, 17 Dec 2020 10:07:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CxSNq1Myfz3DP4; Thu, 17 Dec 2020 10:07:54 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 0BHA7fNT011075 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 17 Dec 2020 12:07:44 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 0BHA7fNT011075 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 0BHA7fi3011074; Thu, 17 Dec 2020 12:07:41 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 17 Dec 2020 12:07:41 +0200 From: Konstantin Belousov To: Antoine Brodin Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Subject: Re: svn commit: r368692 - in head: include/xlocale lib/libc/include lib/libc/nls lib/libc/string Message-ID: References: <202012160902.0BG92A19072702@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4CxSNq1Myfz3DP4 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2020 10:07:55 -0000 On Thu, Dec 17, 2020 at 10:32:14AM +0100, Antoine Brodin wrote: > On Wed, Dec 16, 2020 at 10:02 AM Konstantin Belousov wrote: > > > > Author: kib > > Date: Wed Dec 16 09:02:09 2020 > > New Revision: 368692 > > URL: https://svnweb.freebsd.org/changeset/base/368692 > > > > Log: > > Implement strerror_l(). > > > > Only for the arches that provide user-mode TLS. > > > > PR: 251651 > > Requested by: yuri > > Discussed with: emaste, jilles, tijl > > Sponsored by: The FreeBSD Foundation > > Differential revision: https://reviews.freebsd.org/D27495 > > MFC after: 2 weeks > > Hi, > > It seems that this change broke some ports. > For instance: > http://gohan03.nyi.freebsd.org/data/head-amd64-default-baseline/p558245_s368709/logs/errors/p11-kit-0.23.22.log p11-kit does strange/stupid thing. It checks for strerror_l() without namespace restriction, but then in common/message.c, before actually using it, it does #define _POSIX_C_SOURCE 200112L Could you please try the following, which might be a right thing to do regardless p11-kit quirk. diff --git a/include/string.h b/include/string.h index 3c5cceaeb85..774cf5fe975 100644 --- a/include/string.h +++ b/include/string.h @@ -140,7 +140,7 @@ int timingsafe_bcmp(const void *, const void *, size_t); int timingsafe_memcmp(const void *, const void *, size_t); #endif /* __BSD_VISIBLE */ -#if __POSIX_VISIBLE >= 200809 || defined(_XLOCALE_H_) +#if __POSIX_VISIBLE >= 200112 || defined(_XLOCALE_H_) #include #endif