From owner-svn-src-all@FreeBSD.ORG Sun Jul 27 08:29:13 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2B9E1D4D; Sun, 27 Jul 2014 08:29:13 +0000 (UTC) Received: from mail-wi0-x230.google.com (mail-wi0-x230.google.com [IPv6:2a00:1450:400c:c05::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 21879230B; Sun, 27 Jul 2014 08:29:11 +0000 (UTC) Received: by mail-wi0-f176.google.com with SMTP id bs8so2918212wib.3 for ; Sun, 27 Jul 2014 01:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=EvV3PMdxy2afjuX0qdSpl6fYMJhEsrGz4mj0K6iXTNU=; b=vuneaS5nNPm0bdEjUyoS3Yj5vcyqRSf5/N9eu74f6X0hrWG78Zbu5zRtCRLm4+UeBU rjF6PQ+Th2ybX9rtvgmroBGtt0z9K3AbnjjfYxMJgCOPI7R7qZKxOgE8Aq0SKpcFktnC HQddzW5pDv0WOBqJ4QfL77GaECDceDbFo9HEZyH0QqI/E4GrqKmhziiPT+AN/vKkwG/o 64AXmK//OP3W/svty5hTVRpvGQzexI7oQSLlAB/Tmstst68HflJAaqs9/liRLzYtmwEA kxUL6Qsj/sXl4gYswU5Exk/866IFkSkghgFgmBPYQnxz8WTfEpcXuL5goRvwsl18EQze bnMg== X-Received: by 10.180.101.136 with SMTP id fg8mr19450271wib.44.1406449749916; Sun, 27 Jul 2014 01:29:09 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([134.249.139.101]) by mx.google.com with ESMTPSA id u10sm16799545wix.14.2014.07.27.01.29.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 27 Jul 2014 01:29:09 -0700 (PDT) Sender: Alexander Motin Message-ID: <53D4B853.8040305@FreeBSD.org> Date: Sun, 27 Jul 2014 11:29:07 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Adrian Chadd Subject: Re: svn commit: r268584 - head/sys/dev/sound/pci/hda References: <201407131031.s6DAVTja093433@svn.freebsd.org> <53C335EF.2090606@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Mark Johnston , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jul 2014 08:29:13 -0000 On 27.07.2014 11:20, Adrian Chadd wrote: > ok, so how do I figure out what the right patch should be? > > pcm0: at nid 22 and 24 on hdaa0 > pcm1: at nid 26 and 29 on hdaa0 > > .. and > > hdac0@pci0:0:27:0: class=0x040300 card=0x20f217aa chip=0x293e8086 > rev=0x03 hdr=0x00 Technically there is not all of required info shown above, but assuming some likeness I would try this (just replace ZZZ with your model name): Index: hdaa_patches.c =================================================================== --- hdaa_patches.c (revision 269151) +++ hdaa_patches.c (working copy) @@ -340,7 +340,8 @@ hdac_pin_patch(struct hdaa_widget *w) } } } else if (id == HDA_CODEC_CX20561 && - subid == LENOVO_B450_SUBVENDOR) { + (subid == LENOVO_B450_SUBVENDOR || + subid == LENOVO_ZZZ_SUBVENDOR)) { switch (nid) { case 22: patch = "as=1 seq=15"; Index: hdac.h =================================================================== --- hdac.h (revision 269151) +++ hdac.h (working copy) @@ -236,6 +236,7 @@ #define LENOVO_X1CRBN_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21f9) #define LENOVO_X220_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21da) #define LENOVO_X300_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x20ac) +#define LENOVO_ZZZ_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x20f2) #define LENOVO_T420_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21ce) #define LENOVO_T430_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21f3) #define LENOVO_T430S_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x21fb) -- Alexander Motin