From owner-freebsd-bugs@freebsd.org Wed Jun 24 10:17:58 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D06EB34A612 for ; Wed, 24 Jun 2020 10:17:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 49sJxf5DvMz3dV8 for ; Wed, 24 Jun 2020 10:17:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B3B0C34A71C; Wed, 24 Jun 2020 10:17:58 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B374934A3B6 for ; Wed, 24 Jun 2020 10:17:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49sJxf4KLGz3d5C for ; Wed, 24 Jun 2020 10:17:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8FAEF101BE for ; Wed, 24 Jun 2020 10:17:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 05OAHwkg022211 for ; Wed, 24 Jun 2020 10:17:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 05OAHwWC022205 for bugs@FreeBSD.org; Wed, 24 Jun 2020 10:17:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 247519] Success status on error in Makefile.xtra may cause loss of valuable data Date: Wed, 24 Jun 2020 10:17:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: se@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jun 2020 10:17:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247519 Bug ID: 247519 Summary: Success status on error in Makefile.xtra may cause loss of valuable data Product: Base System Version: Unspecified Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: misc Assignee: bugs@FreeBSD.org Reporter: se@FreeBSD.org Created attachment 215904 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D215904&action= =3Dedit Make error case return error exit status When the condition for e.g. "ERROR: 'buildworld' is not a valid target for = ..." is hit, make exits with a status of 0 indicating success. This is a problem if "etcupdate" is used in such a situation, leading to an empty current directory and deletion of all rc files from /etc. To repeat: # cd /usr/src # env WITH_DIRDEPS_BUILD=3Dyes make buildworld ERROR: 'buildworld' is not a valid target for amd64. You can see the targets which are valid for a given machine by running 'env MACHINE=3D make show-valid-targets' For other information, read:=20 # echo $? 0 (Besides WITH_DIRDEPS_BUILD=3Dyes being suggested in the context of WITH_META_MODE=3Dyes and leading to no targets being accepted except for the destroy targets, the above error text stops after "read:" without giving any indication what to read ...) # env MACHINE=3Damd64 make show-valid-targets Other targets: destroy destroy-arch destroy-host destroy-stage The attached diff might not be the best solution, but it does at least prev= ent the removal of the rc files if etcupdate is invoked in such a situation. --=20 You are receiving this mail because: You are the assignee for the bug.=