Date: Mon, 9 Oct 2000 23:59:00 -0700 From: Jeremy Lea <reg@FreeBSD.ORG> To: Akinori MUSHA <knu@idaemons.org> Cc: asami@FreeBSD.ORG, yasuf@bsdclub.org, leeym@bsd.ce.ntu.edu.tw, knu@FreeBSD.ORG, kevlo@FreeBSD.ORG, ade@FreeBSD.ORG, ports@FreeBSD.ORG Subject: Re: New order check done Message-ID: <20001009235900.N30468@shale.csir.co.za> In-Reply-To: <86og0twic9.wl@archon.local.idaemons.org>; from knu@idaemons.org on Tue, Oct 10, 2000 at 11:17:10AM %2B0900 References: <200010092150.e99LokA95039@silvia.hip.berkeley.edu> <86og0twic9.wl@archon.local.idaemons.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
On Tue, Oct 10, 2000 at 11:17:10AM +0900, Akinori MUSHA wrote:
> It was caused because someone removed the below line:
>
> CONFIGURE_ARGS= ${GTK_CONFIG}
>
> Ruby-gtk's configure script is _not_ a GNU one and it takes
> gtk-config's name as the first command line argument followed by some
> options that start with "--".
Sorry, that was me. The configure script finds imlib-config if it is
installed, so it was passing my test builds with WITHOUT_IMLIB=yes, and
I couldn't find any use for the CONFIGURE_ARGS, since the port didn't
define (HAS|GNU)_CONFIGURE. You might want to consider using
EXTCONF_ARGS rather than reusing CONFIGURE_ARGS.
> I confirmed the following patch fixes it. Fukuma-san, would you
> approve this change?
>
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/ports/x11-toolkits/ruby-gtk/Makefile,v
> retrieving revision 1.15
> diff -u -r1.15 Makefile
> --- Makefile 2000/10/08 10:23:45 1.15
> +++ Makefile 2000/10/10 01:52:45
> @@ -15,14 +15,14 @@
>
> MAINTAINER= yasuf@bsdclub.org
>
> -WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
> -
> USE_RUBY= yes
> USE_RUBY_EXTCONF= yes
> USE_XLIB= yes
> USE_GTK= yes
> WANT_IMLIB= yes
>
> +WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
> +CONFIGURE_ARGS= ${GTK_CONFIG}
> INSTALL_TARGET= site-install
WRKSRC should be between the DEPENDS and USE sections, IIRC, and
CONFIGURE_ARGS should be part of the USE section and seperated from
INSTALL_TARGET by an empty line.
-Jeremy
--
FreeBSD - Because the best things in life are free...
http://www.freebsd.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001009235900.N30468>