Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Jul 2021 01:37:33 GMT
From:      Craig Leres <leres@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: 4defa21352e4 - main - graphics/netpbm: Don't install dangling symlink when PERL is not selected
Message-ID:  <202107250137.16P1bXqi009325@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by leres:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4defa21352e4e5b0a449e91b06ac52258dc213bf

commit 4defa21352e4e5b0a449e91b06ac52258dc213bf
Author:     Craig Leres <leres@FreeBSD.org>
AuthorDate: 2021-07-25 01:35:14 +0000
Commit:     Craig Leres <leres@FreeBSD.org>
CommitDate: 2021-07-25 01:35:14 +0000

    graphics/netpbm: Don't install dangling symlink when PERL is not selected
    
    As per the PR, a symlink for pnmquantall was getting installed
    for the binary and man page with the PERL option off.
    
    While we're here, fix a portlint nit (sed -> ${SED).
    
    Take maintainership.
    
    PR:             255658
    Reported by:    Philippe Michel
---
 graphics/netpbm/Makefile  | 4 ++--
 graphics/netpbm/pkg-plist | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/graphics/netpbm/Makefile b/graphics/netpbm/Makefile
index 9faf5f6088bf..aeea4faea4db 100644
--- a/graphics/netpbm/Makefile
+++ b/graphics/netpbm/Makefile
@@ -5,7 +5,7 @@ DISTVERSION=	10.91.01
 CATEGORIES=	graphics
 MASTER_SITES=	https://github.com/t6/netpbm/releases/download/v${DISTVERSION}/
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	leres@FreeBSD.org
 COMMENT=	Toolkit for conversion of images between different formats
 
 LICENSE=	GPLv2 IJG LGPL21 MIT PD
@@ -120,7 +120,7 @@ NETPBM_REPO=	https://svn.code.sf.net/p/netpbm/code
 NETPBM_SERIES=	advanced
 
 netpbm-version-check:
-	@REV=`svnlite info ${NETPBM_REPO}/${NETPBM_SERIES}/version.mk | sed -n 's/Last Changed Rev: //p'`; \
+	@REV=`svnlite info ${NETPBM_REPO}/${NETPBM_SERIES}/version.mk | ${SED} -n 's/Last Changed Rev: //p'`; \
 	VERSION=`(svnlite cat -r$$REV ${NETPBM_REPO}/${NETPBM_SERIES}/version.mk; \
 			echo 'all:'; \
 			echo '	@printf "%02d.%02d.%02d" \'; \
diff --git a/graphics/netpbm/pkg-plist b/graphics/netpbm/pkg-plist
index 786a713deb1e..0752b1c60337 100644
--- a/graphics/netpbm/pkg-plist
+++ b/graphics/netpbm/pkg-plist
@@ -294,7 +294,7 @@ bin/ppmnorm
 bin/ppmntsc
 bin/ppmpat
 %%PERL%%bin/ppmquant
-bin/ppmquantall
+%%PERL%%bin/ppmquantall
 %%PERL%%bin/ppmrainbow
 bin/ppmrelief
 bin/ppmrough
@@ -699,7 +699,7 @@ lib/libnetpbm.so.11.91
 %%MANPAGES%%man/man1/ppmntsc.1.gz
 %%MANPAGES%%man/man1/ppmpat.1.gz
 %%PERL%%%%MANPAGES%%man/man1/ppmquant.1.gz
-%%MANPAGES%%man/man1/ppmquantall.1.gz
+%%PERL%%%%MANPAGES%%man/man1/ppmquantall.1.gz
 %%PERL%%%%MANPAGES%%man/man1/ppmrainbow.1.gz
 %%MANPAGES%%man/man1/ppmrelief.1.gz
 %%MANPAGES%%man/man1/ppmrough.1.gz



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202107250137.16P1bXqi009325>