From nobody Tue May 23 06:06:08 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QQP2Y6vxDz4T6Ls for ; Tue, 23 May 2023 06:06:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QQP2Y4KB0z42cb for ; Tue, 23 May 2023 06:06:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-51f6461af24so4705862a12.2 for ; Mon, 22 May 2023 23:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684821970; x=1687413970; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=c4mpTkkx+36Y5hNPjhEyOgejchh9F7uyViPAHhBRxy0=; b=BzLmK9YLmx4V9wVEnrp5TMaAcSE8eFHnmKytPDYLUUR3za6nS+xeM+JiA1rAksDo4/ BhgcG1D7IdtiV3an2JTOzu1nyvHMqVZAuNL4Z/lN+ccYeU8W4P3teNoDBjngL4Ws4l90 i7I3Grvvq0CE1Cfe4fiK4Ps8pG0NboIh2itOZHgNIVq88+Q6luHon5QTTq91MrK4qWCZ IJl5nD52hrqtLcy0+OAigqYMgCGyFJCsknqzeWaG2d3BASfbGnPqYImtIGkkDtsaioTy OmbAT/3P462QQyKuBwzU5cELuZSCTHsAinaKZdl4TChcVflhZMYg46iPcAAiCIaM+jb9 oOCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684821970; x=1687413970; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c4mpTkkx+36Y5hNPjhEyOgejchh9F7uyViPAHhBRxy0=; b=YDuBdzX+lEsCEmsXrKeF5k3uaLpYHvBTHdLBkh6XZorTQBqpxFP9/9JHAm/He4GIY9 eW+L+0KRzIliGjiErLG0RGk1Acmx6u81poKf4MJu26x+6s55anRZcuJcjsQvxHHHkeMH fxzuenAxbWjDkw2DK+KlN9x+Q7JJsyHKluC+PTiUz6jUW8RWxiDIJRB1WPXkPitWMUQB 5+FrYxj5WX2SeslzNEPACBMNbGTzj8Fnxnffk3bFWu1xOCv51hEqBDaeEvv91FO/Qaq0 uWNhSzEqunEEsfPzMJwVWZl9NJrOxO3XJzcYYtlpaNzjCiS+tCE1xc4IN2fcfk7+H0kc n5gQ== X-Gm-Message-State: AC+VfDw6kLScbpV5cQdnUUneAiWXT3/yjBnBPszS3ttJrBG4HjFnc5OG HqEvJSW4EVCES0H0nrOzrbz5jrf7GpIkAw== X-Google-Smtp-Source: ACHHUZ7I3rcUBI7Nnq2eOgiium5tPZRNpCIDNBxi2fI30j8gvlKo+lUIwFSjzrswaR7o/c4cgrq86w== X-Received: by 2002:a17:902:eb46:b0:1ac:9cad:1845 with SMTP id i6-20020a170902eb4600b001ac9cad1845mr13350785pli.18.1684821970214; Mon, 22 May 2023 23:06:10 -0700 (PDT) Received: from smtpclient.apple (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id je3-20020a170903264300b001a9581d3ef5sm5894793plb.97.2023.05.22.23.06.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2023 23:06:09 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_9AF78CF0-6B76-4B17-AEBB-562F49C176B4"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: MOTD is not created correctly (since 2022/02/18) From: Enji Cooper In-Reply-To: <202305230318.34N3IOaX056503@donotpassgo.dyslexicfish.net> Date: Mon, 22 May 2023 23:06:08 -0700 Cc: freebsd-current@freebsd.org Message-Id: <1FA0E3FF-9DF6-46BA-81C1-4DCE5542CAD5@gmail.com> References: <202305230318.34N3IOaX056503@donotpassgo.dyslexicfish.net> To: Jamie Landeg-Jones X-Mailer: Apple Mail (2.3696.120.41.1.3) X-Rspamd-Queue-Id: 4QQP2Y4KB0z42cb X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_9AF78CF0-6B76-4B17-AEBB-562F49C176B4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 22, 2023, at 8:18 PM, Jamie Landeg-Jones = wrote: >=20 > I've just finally updated to 13-stable, and can't be the first to = notice this?! >=20 > /etc/rc.d/motd contains the line: >=20 > uname -v | sed -e 's,^\([^#]*\) #\(.* = [1-2][0-9][0-9][0-9]\).*/\([^\]*\) $,\1 (\3) #\2,' >=20 > Note the space before the "$" - needed because the uname -v output = used > to have a trailing space. This was fixed and comitted on 2022/02/18: >=20 > = https://cgit.freebsd.org/src/commit/usr.bin/uname/uname.c?id=3D7e05fa3b449= 007adaa6e588ebb3b8d76f30b355c >=20 > Since then, the sed doesn't match, so the uname(1) output is = unchanged. >=20 > There's no point altering the sed to work with both posibilities, so = can > someone commit the fix of removing the ' ' before the '$' in = /etc/rc.d/motd ? Hi Jamie, Thank you for the note =E2=80=94 could you please file a PR and = reference it in a reply? Thanks! -Enji --Apple-Mail=_9AF78CF0-6B76-4B17-AEBB-562F49C176B4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEtvtxN6kOllEF3nmX5JFNMZeDGN4FAmRsV9AACgkQ5JFNMZeD GN7PshAAjWKj1sYPmTM3BkILKRihqAgR+ElpBkBL8ElkIOnS8vea8KchdocSd6DN wjouseX6oM4uiiccFurL0WkB98IaZp/Yl6wNVuHMMO5/KbrKbhqWgEtsCvsykvqC gAqcWEidlwKcEng65/9ef+n59hVzS5tT+fRuMLfJzkAEuIHTR4cWVi8/HnODxB8z XkETMWOlTCiLk12DaY2JRCUG/2M3D1ww2LsVQQepJt0cqwNRegfY2xB7Zag6+JU4 RGaIrmjU4JfJlcxBUK/jvpsEQgiKWsYVZnJTixERONTF5W/pZ+ljYcwJ4jUF+P25 xG+8Zm4r3z25wJN7UxMAJeG31IPUU8N9s4to/e5D9DaNH8aG3TChYLTu7OuH3mfi eqUHaoxB0tZVFtg0NpuJ2veC4HRPU17TEIlJEWkjIQ2TG54unENypFSE50+dekbL t5UObylbjOEaXyP8Ia71x3KFuOmCfAjFlM2/RgAcA78Ba8kQOljvsDMZeMXoBTCk /BbJEUwT1rkKBkUahMYYwRtgohN7JU1FGp1qE35mCJh/rpudAE6V792sf0FPsxQB lP8NSTxfod3ogo/URxvZztB7EyBkeODtdKWYf893Wn/oOhtY2I9m/nbHeHQcrpIP Ge66H9IAE+0F5yCTjp4B0Eub/Mzi1hZYxSKrQgbIhrPIEgWf4cM= =QmZa -----END PGP SIGNATURE----- --Apple-Mail=_9AF78CF0-6B76-4B17-AEBB-562F49C176B4--