From owner-svn-src-stable@freebsd.org Wed Aug 15 19:43:24 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8C80F106E39B; Wed, 15 Aug 2018 19:43:24 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3D3F17789C; Wed, 15 Aug 2018 19:43:24 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id D157E16F94; Wed, 15 Aug 2018 19:43:23 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f51.google.com with SMTP id j143-v6so1675786lfj.12; Wed, 15 Aug 2018 12:43:23 -0700 (PDT) X-Gm-Message-State: AOUpUlEtxO6dn4KE16yKKYkf2il5bkoWvovtBfvJ49te+Hj3GJNzSjCp /qGDIvz84ltHbTqTyTFNGV+KyU6GxeI9jpLJ6Ac= X-Google-Smtp-Source: AA+uWPxa/0EFpNztpA2qi+/hp/ijaTpRtC2yb+Ogp7fulgNIXuaCGeKwC0Opas/K6xej3i/OwweWzhvgD6QYiPtNr8E= X-Received: by 2002:a19:ded7:: with SMTP id i84-v6mr2082353lfl.146.1534362202493; Wed, 15 Aug 2018 12:43:22 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:5742:0:0:0:0:0 with HTTP; Wed, 15 Aug 2018 12:43:01 -0700 (PDT) In-Reply-To: <201808151934.w7FJYloG049357@pdx.rh.CN85.dnsmgr.net> References: <201808151934.w7FJYloG049357@pdx.rh.CN85.dnsmgr.net> From: Kyle Evans Date: Wed, 15 Aug 2018 14:43:01 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r337826 - stable/11/bin/ls To: "Rodney W. Grimes" Cc: Adam Weinberger , svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers , Ed Maste , svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 19:43:24 -0000 On Wed, Aug 15, 2018 at 2:34 PM, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> On Wed, Aug 15, 2018 at 12:43 PM, Rodney W. Grimes >> wrote: >> > >> > From the Linux man page at: http://man7.org/linux/man-pages/man1/ls.1.html >> > >> > Using color to distinguish file types is disabled both by default and >> > with --color=never. With --color=auto, ls emits color codes only >> > when standard output is connected to a terminal. The LS_COLORS >> > environment variable can change the settings. Use the dircolors >> > command to set it. >> > >> > Um, so by default we should not be doing any colour... and we are... >> > >> >> I don't recall making any argument that we're trying to match GNU >> ls(1) behavior. Furthermore, again, we aren't doing any color by >> default- only when the COLORTERM environment variable is set. > > So we are intentially being different? > No, we are not intentionally being different. See: the next paragraph, where I described that we've now-historically been honoring an environment variable for this and have simply added a more standard name for this variable. >> >> ls(1) on FreeBSD historically honors -an- environment variable for >> enabling color. > > Short history, long history it had no color support at all. Color support in ls(1) is now old enough to drink having been introduced in 2000- I think that's long enough to call it "historically" here in 2018. > >> This environment variable is CLICOLOR. This commit >> switched the environment variable honored to the more-standard >> COLORTERM that is honored in other software and set by terminals that >> are generally expected to be used with color. >> >> I'm writing an UPDATING entry for this now to notify these users that >> they should remove COLORTERM from their environment if they do not, in >> fact, want a colored terminal. > > Is that the only way to turn this off? > That may not be desired either. > Atleast GNU ls allows me to force it off on command invocation > with --color=never, do we have an equivelent? > Sure- it gets turned off the same way it got turned on. =) I'm certainly not averse to adding a --color long option, and will do so when I find the time (later today, most likely). Thanks, Kyle Evans