From owner-freebsd-ports@freebsd.org Wed Nov 6 05:43:58 2019 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 48F5917E279 for ; Wed, 6 Nov 2019 05:43:58 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 477Fp52ngnz4pTc for ; Wed, 6 Nov 2019 05:43:57 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: by mail-io1-xd2f.google.com with SMTP id r144so25625576iod.8 for ; Tue, 05 Nov 2019 21:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=3FY2pVtzaxNmhq64ZdTd0s7tvdjdNyPUVUO4n69n2v8=; b=BXwRXARpwZFkfluWtvU7XB4S5+CJ0V20CYXej7p9lh1zrH28kkV9oq+md9RgX/teQw quVUB06bPaINfnWE8zGbI6z2ps9BIsXvvzKHjsm6ZVYVjgDbICTXIymEg/4XMe8MnXbD y3k7590/Ksj+UeXgLvTgkw1d/IR018gpPivwfYf4nQEcaFC+zr3ViNlPjlJ/hqOD6fa1 OpO2jhe0Bba+C2fWg/00Me3geDnMf9A1vpF1BObhlzivkf6cy42IvLQfGTZ2iDGK2GGZ rnJ/WIO3BB5/OS9+/a55Y7rM3NFRtKhUCTJE+VD273ofbTxfSwDTeqofk2afNRl8Wbev QhLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3FY2pVtzaxNmhq64ZdTd0s7tvdjdNyPUVUO4n69n2v8=; b=hyVqyyadHRuREOsWg76zQ+ynPOryaLWD9u35IY3djAuhGlGirrmE2iO7YUqkdgAdF3 BYqyywozx4xUoq+OeQkzCClx+/xOyYzelqVZ7hM7pgPcDviwWhJkbxi2wtgEwdv+t+u8 eJkTxNZXMUDz8ish3KyYfYedzTpwgb9rwlbwPz4ksx1YxIf5RwxDtaIHxGnbNEDuLIRe P8h2fPCkSNq3AHlCNdn5kEDvZIATvyi2WIBmpH0h8Yf5TjnZE5KMDCSkIrazVIX7G5Om UT5U72Ehs7kRjKd/xNAeaaNWqZhyTM0I+UOVzCV38ouLOEC2jC9b0F/RuMZsSQ+lqdlo nK/g== X-Gm-Message-State: APjAAAXYOeUsxKvmIPdDTwGEHrkT74vQa1d2UuqHaooElCU0+6SO0zSo OpfGNIb//noOJn6Oj9xDXfqs7C1e2qk0u6Ql2dn2sIcB X-Google-Smtp-Source: APXvYqyEnIR+kqL3HGtV472K8RBXWXUUtcLrJGxoBmi813xm7ap7BS+cLig03TigLHFf1EfBoQhU5jCL5WgfS4Dsp8o= X-Received: by 2002:a05:6602:2216:: with SMTP id n22mr30380900ion.114.1573019035893; Tue, 05 Nov 2019 21:43:55 -0800 (PST) MIME-Version: 1.0 From: Russell Haley Date: Tue, 5 Nov 2019 21:43:48 -0800 Message-ID: Subject: Adding FLAVORS to lua-luarocks To: freebsd-ports@freebsd.org X-Rspamd-Queue-Id: 477Fp52ngnz4pTc X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=BXwRXARp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of russhaley@gmail.com designates 2607:f8b0:4864:20::d2f as permitted sender) smtp.mailfrom=russhaley@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_NONE(0.00)[]; URI_COUNT_ODD(1.00)[7]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-6.30), ipnet: 2607:f8b0::/32(-2.36), asn: 15169(-2.02), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_IN_DNSWL_NONE(0.00)[f.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Nov 2019 05:43:58 -0000 Hello, I have a review for updating the Lua package manager - LuaRocks - it to the latest revision, 3.2.1. The new port file uses an update to lua.mk from Andrew Gierth for using FLAVORS to support all available versions of Lua. The reviews are here: (LuaRocks) https://reviews.freebsd.org/D17814 and here: (Lua.mk) https://reviews.freebsd.org/D16494 In the LuaRocks port, I've added the flavors as a selection of port OPTIONS to build the correct version. Unfortunately, using the OPTIONS isn't ideal because it will save the selected option for the next time the port is run, but that's not the desired use case. I wanted the build to *always* prompt for a Lua version so it can be used for multiple side by side Lua installations. Any suggestions, alternatives to OPTIONS or other constructive input would be appreciated. Cheers, Russ