From owner-freebsd-current@FreeBSD.ORG Wed Jun 15 15:37:59 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A908106566B; Wed, 15 Jun 2011 15:37:59 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from mailrelay.rz.uni-wuerzburg.de (wrz3028.rz.uni-wuerzburg.de [132.187.3.28]) by mx1.freebsd.org (Postfix) with ESMTP id 2895C8FC12; Wed, 15 Jun 2011 15:37:58 +0000 (UTC) Received: from virusscan.mail (localhost [127.0.0.1]) by mailrelay.mail (Postfix) with ESMTP id 774BF5AD00; Wed, 15 Jun 2011 17:37:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by virusscan.mail (Postfix) with ESMTP id 7551D5AC70; Wed, 15 Jun 2011 17:37:56 +0200 (CEST) X-Virus-Scanned: by amavisd-new at uni-wuerzburg.de Received: from mail.physik.uni-wuerzburg.de (wthp192.physik.uni-wuerzburg.de [132.187.40.192]) by mailmaster.uni-wuerzburg.de (Postfix) with ESMTP id 4949C5D0D9; Wed, 15 Jun 2011 17:37:56 +0200 (CEST) Received: from lexx.ifp.tuwien.ac.at ([128.131.127.223]) by mail.physik.uni-wuerzburg.de (Lotus Domino Release 8.5.2FP2HF144) with ESMTP id 2011061517260255-101426 ; Wed, 15 Jun 2011 17:26:02 +0200 Date: Wed, 15 Jun 2011 17:26:01 +0200 From: Alexey Shuvaev To: John Baldwin Message-ID: <20110615152601.GA65255@lexx.ifp.tuwien.ac.at> References: <201105231039.02845.jhb@freebsd.org> <201106101511.02809.jhb@freebsd.org> <20110614144418.GA38374@lexx.ifp.tuwien.ac.at> <201106141134.34611.jhb@freebsd.org> MIME-Version: 1.0 In-Reply-To: <201106141134.34611.jhb@freebsd.org> Organization: Universitaet Wuerzburg User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on domino1/uni-wuerzburg(Release 8.5.2FP2HF144 | May 11, 2011) at 06/15/2011 05:26:02 PM, Serialize by Router on domino1/uni-wuerzburg(Release 8.5.2FP2HF144 | May 11, 2011) at 06/15/2011 05:37:55 PM, Serialize complete at 06/15/2011 05:37:55 PM Content-Type: multipart/mixed; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] Simple tidy up of puc(4) bus driver X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2011 15:37:59 -0000 --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 14, 2011 at 11:34:34AM -0400, John Baldwin wrote: > On Tuesday, June 14, 2011 10:44:18 am Alexey Shuvaev wrote: > > On Fri, Jun 10, 2011 at 03:11:02PM -0400, John Baldwin wrote: > > > On Monday, May 23, 2011 10:39:02 am John Baldwin wrote: > > > > This small patch makes the puc(4) bus drivers a little more friendly. It > > > > should now list the port for each child device in the boot messages, and > > > > devinfo -v should list the type and port of each child device in its output as > > > > well: > > > > > > Can I get a volunteer to test these changes? > > > > > Would it be OK to use r202285 as a base for your patch? > > If so, I will test it today/tomorrow. If not, it will take a little bit > > longer... > > Yes, it should apply fine to that. It doesn't touch pucdata.c which is the > only thing in the puc driver that has changed since that revision. Thanks! > Seems to work fine. Attached are relevant diff-s of dmesg.boot and devinfo -v output. Alexey. --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="dmesg.boot_diff" --- dmesg.boot_old 2011-06-15 16:18:52.000000000 +0200 +++ dmesg.boot_new 2011-06-15 16:23:56.000000000 +0200 @@ -49,11 +49,11 @@ pcm0: puc0: port 0x7c00-0x7c07,0x8000-0x8007,0x8400-0x8407,0x8800-0x8807,0x8c00-0x8c07,0x9000-0x900f irq 7 at device 10.0 on pci0 puc0: [FILTER] -uart2: on puc0 +uart2: at port 1 on puc0 uart2: [FILTER] -uart3: on puc0 +uart3: at port 2 on puc0 uart3: [FILTER] -ppc0: on puc0 +ppc0: at port 3 on puc0 ppc0: SMC-like chipset (ECP/EPP/PS2/NIBBLE) in COMPATIBLE mode ppc0: FIFO with 16/16/12 bytes threshold ppbus0: on ppc0 --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=devinfo_diff --- devinfo_old 2011-06-15 16:19:03.000000000 +0200 +++ devinfo_new 2011-06-15 16:24:02.000000000 +0200 @@ -38,9 +38,9 @@ hostb1 pnpinfo vendor=0x1106 device=0x3057 subvendor=0x0000 subdevice=0x0000 class=0x060000 at slot=7 function=4 handle=\_SB_.PCI0.VTAC pcm0 pnpinfo vendor=0x1106 device=0x3058 subvendor=0x11d6 subdevice=0x7358 class=0x040100 at slot=7 function=5 puc0 pnpinfo vendor=0x9710 device=0x9835 subvendor=0x1000 subdevice=0x0012 class=0x078000 at slot=10 function=0 - uart2 - uart3 - ppc0 + uart2 pnpinfo type=1 at port=1 + uart3 pnpinfo type=1 at port=2 + ppc0 pnpinfo type=2 at port=3 ppbus0 plip0 lpt0 --LQksG6bCIzRHxTLp--