From owner-freebsd-ports  Tue Feb 18 16:50:08 1997
Return-Path: <owner-ports>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id QAA15474
          for ports-outgoing; Tue, 18 Feb 1997 16:50:08 -0800 (PST)
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id QAA15464;
          Tue, 18 Feb 1997 16:50:04 -0800 (PST)
Resent-Date: Tue, 18 Feb 1997 16:50:04 -0800 (PST)
Resent-Message-Id: <199702190050.QAA15464@freefall.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-ports
Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, marcs@znep.com
Received: from vole.worldgate.com (vole.worldgate.com [198.161.84.13])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id QAA14651
          for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Feb 1997 16:42:30 -0800 (PST)
Received: (from marcs@localhost)
	by vole.worldgate.com (8.8.5/8.8.5) id RAA00230;
	Tue, 18 Feb 1997 17:42:19 -0700 (MST)
Message-Id: <199702190042.RAA00230@vole.worldgate.com>
Date: Tue, 18 Feb 1997 17:42:19 -0700 (MST)
From: marcs@znep.com
Reply-To: marcs@znep.com
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: ports/2765: gopher port uses gets()
Sender: owner-ports@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         2765
>Category:       ports
>Synopsis:       gopher port uses gets()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 18 16:50:02 PST 1997
>Last-Modified:
>Originator:     Marc Slemko
>Organization:
>Release:        FreeBSD 2.2-GAMMA i386
>Environment:

gopher-2.1.3 port

>Description:

>From gopher2_1_3/gopher/upload.c:
               while(gets(inputline)) {
                    ZapCRLF(inputline);
                    if (strcmp(inputline, ".") == 0) 
                         break;
                    FIOwritestring(fio, inputline);
               }

Yea, yea, no one uses gopher any more (although I am quite tempted
after re-experiencing how fast it is...) but...

>How-To-Repeat:


>Fix:

*** upload.c.dist	Tue Feb 18 17:31:30 1997
--- upload.c	Tue Feb 18 17:40:22 1997
***************
*** 123,129 ****
  		    CURenter();
  		    return;
  	       }
! 	       while(gets(inputline)) {
  		    ZapCRLF(inputline);
  		    if (strcmp(inputline, ".") == 0) 
  			 break;
--- 123,129 ----
  		    CURenter();
  		    return;
  	       }
! 	       while(fgets(inputline, 256, stdin)) {
  		    ZapCRLF(inputline);
  		    if (strcmp(inputline, ".") == 0) 
  			 break;

>Audit-Trail:
>Unformatted: