From owner-svn-src-head@FreeBSD.ORG Sat Aug 6 22:07:51 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C2D20106566C; Sat, 6 Aug 2011 22:07:51 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 5A1EA8FC0C; Sat, 6 Aug 2011 22:07:51 +0000 (UTC) Received: by vws18 with SMTP id 18so1665520vws.13 for ; Sat, 06 Aug 2011 15:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=g338jJKC3BrAN90s420DB2OKQeIdIG0Hk1DKODVeRoc=; b=rFVww9vzK7fIBrkUHODhN4kgHIA2Vrt8Soxo48J0LRnDL3GtruJMMYIW0L+qWMil6l 9dwmuFMw4r/VTci/8qVR7BvaOLcQZmpIOHPnKXjOO9awORzqXAkBUpPMty4VyWkQljoH T2pPzQ92UfBkt6HChjMG/Eo6tHAzTg3mKETmo= MIME-Version: 1.0 Received: by 10.220.84.65 with SMTP id i1mr1170032vcl.54.1312666888668; Sat, 06 Aug 2011 14:41:28 -0700 (PDT) Received: by 10.220.172.18 with HTTP; Sat, 6 Aug 2011 14:41:28 -0700 (PDT) In-Reply-To: <4E3DA560.6020100@yandex.ru> References: <201108061748.p76HmUbM061259@svn.freebsd.org> <4E3DA560.6020100@yandex.ru> Date: Sat, 6 Aug 2011 14:41:28 -0700 Message-ID: From: Garrett Cooper To: Ruslan Mahmatkhanov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, Marius Strobl , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r224683 - head/lib/libthread_db X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Aug 2011 22:07:51 -0000 On Sat, Aug 6, 2011 at 1:34 PM, Ruslan Mahmatkhanov wro= te: > Marius Strobl wrote on 06.08.2011 21:48: >> >> Author: marius >> Date: Sat Aug =A06 17:48:30 2011 >> New Revision: 224683 >> URL: http://svn.freebsd.org/changeset/base/224683 >> >> Log: >> =A0 The tid member of struct pthread actually is long so read it as such= . >> =A0 Accessing it as an int causes failure on big-endian LP64, i.e. mips6= 4be, >> =A0 powerpc64 and sparc64. >> >> =A0 Reviewed by: marcel >> =A0 Approved by: re (kib) >> =A0 MFC after: =A0 1 week >> >> Modified: >> =A0 head/lib/libthread_db/libthr_db.c >> > > Hi. > Seems like this or related libthread_db commit breaks the build on i386: > > =3D=3D=3D> lib/libthr (all) > =3D=3D=3D> lib/libthread_db (all) > cc -O2 -pipe =A0-I. -I/usr/src/lib/libthread_db -std=3Dgnu99 -fstack-prot= ector > -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type > -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter > -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decl= s > -Wold-style-definition -Wno-pointer-sign -c > /usr/src/lib/libthread_db/thread_db.c > cc -O2 -pipe =A0-I. -I/usr/src/lib/libthread_db -std=3Dgnu99 -fstack-prot= ector > -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type > -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter > -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decl= s > -Wold-style-definition -Wno-pointer-sign -c > /usr/src/lib/libthread_db/arch/i386/libpthread_md.c > cc -O2 -pipe =A0-I. -I/usr/src/lib/libthread_db -std=3Dgnu99 -fstack-prot= ector > -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type > -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter > -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decl= s > -Wold-style-definition -Wno-pointer-sign -c > /usr/src/lib/libthread_db/libpthread_db.c > cc -O2 -pipe =A0-I. -I/usr/src/lib/libthread_db -std=3Dgnu99 -fstack-prot= ector > -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type > -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter > -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decl= s > -Wold-style-definition -Wno-pointer-sign -c > /usr/src/lib/libthread_db/libthr_db.c > cc1: warnings being treated as errors > /usr/src/lib/libthread_db/libthr_db.c: In function 'pt_ta_map_id2thr': > /usr/src/lib/libthread_db/libthr_db.c:217: warning: passing argument 3 of > 'thr_pread_long' from incompatible pointer type > /usr/src/lib/libthread_db/libthr_db.c: In function 'pt_ta_thr_iter': > /usr/src/lib/libthread_db/libthr_db.c:257: warning: passing argument 3 of > 'thr_pread_long' from incompatible pointer type > /usr/src/lib/libthread_db/libthr_db.c: In function 'pt_ta_event_getmsg': > /usr/src/lib/libthread_db/libthr_db.c:398: warning: passing argument 3 of > 'thr_pread_long' from incompatible pointer type > /usr/src/lib/libthread_db/libthr_db.c: In function 'pt_thr_event_getmsg': > /usr/src/lib/libthread_db/libthr_db.c:702: warning: passing argument 3 of > 'thr_pread_long' from incompatible pointer type It's not just i386. It's other architectures like arm, mips, and pc98 according to the tinderbox reports (this list is potentially incomplete). -Garett