From owner-cvs-all Mon Dec 16 18: 1:20 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA26437B401; Mon, 16 Dec 2002 18:01:18 -0800 (PST) Received: from rwcrmhc52.attbi.com (rwcrmhc52.attbi.com [216.148.227.88]) by mx1.FreeBSD.org (Postfix) with ESMTP id 531EE43EDC; Mon, 16 Dec 2002 18:01:18 -0800 (PST) (envelope-from julian@elischer.org) Received: from InterJet.elischer.org (12-232-168-4.client.attbi.com[12.232.168.4]) by rwcrmhc52.attbi.com (rwcrmhc52) with ESMTP id <2002121702011705200184rve>; Tue, 17 Dec 2002 02:01:17 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id SAA15144; Mon, 16 Dec 2002 18:01:16 -0800 (PST) Date: Mon, 16 Dec 2002 18:01:15 -0800 (PST) From: Julian Elischer To: Matthew Dillon Cc: Nate Lawson , Julian Elischer , cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 dump_machdep.c In-Reply-To: <200212170108.gBH18V4r082434@apollo.backplane.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 16 Dec 2002, Matthew Dillon wrote: > > : > : > : > :On Mon, 16 Dec 2002, Matthew Dillon wrote: > : > :> Hmm. Wouldn't this be easier if the test were done after > :> calculating dumplo? e.g. > :> > :> :> dumplo = di->mediaoffset + di->mediasize - Maxmem * (off_t)PAGE_SIZE; > :> :> dumplo -= sizeof kdh * 2; > :> > : > :no because then you'd have to check fopr dumplo being -ve > :and I'm of the opinion that blocknumbers should always be unsigned (*) > :so if this were ever "corrected" to be unsigned, you'd > :have to check for an overflow which is difficult. > : > :(*) there are many bugs showing up at the moment as disks start to > :get NBLK > 2^31 blocks on them that wouldn't happen if they were > :unsigned.. > : > :I have 3 such devices each with >1TB. > :If you want to see things explode, just try run sysinstall on them. > > Isn't it using off_t there? 64 bit offsets? yep it is now. But I'm not going to depend on it If we change it and later someone makes off_t unsigneor changes it to an unsigned value of some type (off_t is a bad choice I think) then it will continue to work until someone's root partition gets cleared. > > -Matt > Matthew Dillon > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message