Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 09 Feb 2015 17:37:16 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 194215] [maintainer] emulators/dynagen: clean sanity check
Message-ID:  <bug-194215-13-6yQRlYNHnF@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-194215-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-194215-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194215

--- Comment #12 from John Marino <marino@FreeBSD.org> ---
so 
1) remove "pemu-start.sh" from shebang line
2) replace "*.py" with "pemubin.py, pemuwrapper.py" on replace line

No it's not easier but it's (more) clear to the next person which files are
getting changed by what.  

Honestly, it seems that this REPLACE_CMD is replacing unrelated things mainly
to limit itself to one command.  "-e "s|^CONFIGSPECPATH = .*|CONFIGSPECPATH =
\['${PREFIX}/share/dynagen'\]|"" has nothing to do with shebang, so I'd really
prefer a second, dedicated replace_cmd for dynagen

again -- I know it's not easier to change, but it's more maintainable IMO.

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194215-13-6yQRlYNHnF>