From owner-dev-commits-src-branches@freebsd.org Thu Apr 22 11:08:36 2021 Return-Path: Delivered-To: dev-commits-src-branches@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D6A205EBCCD; Thu, 22 Apr 2021 11:08:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FQvmf6Yrzz3kVv; Thu, 22 Apr 2021 11:08:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8A1B418AC7; Thu, 22 Apr 2021 11:08:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 13MB8XQu088799; Thu, 22 Apr 2021 11:08:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 13MB8XNr088798; Thu, 22 Apr 2021 11:08:33 GMT (envelope-from git) Date: Thu, 22 Apr 2021 11:08:33 GMT Message-Id: <202104221108.13MB8XNr088798@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alex Richardson Subject: git: 549e8b821fcf - stable/13 - Fix unused functions in invtrig_test.c MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: arichardson X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 549e8b821fcf102a99bffb995832e01fc9c5108d Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-branches@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the stable branches of the FreeBSD src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 11:08:37 -0000 The branch stable/13 has been updated by arichardson: URL: https://cgit.FreeBSD.org/src/commit/?id=549e8b821fcf102a99bffb995832e01fc9c5108d commit 549e8b821fcf102a99bffb995832e01fc9c5108d Author: Alex Richardson AuthorDate: 2021-03-22 13:05:28 +0000 Commit: Alex Richardson CommitDate: 2021-04-22 09:44:51 +0000 Fix unused functions in invtrig_test.c I only tested the WARNS=6 change on AArch64 and AMD64, but this file has unused functions for architectures with LDBL_PREC == 53. While touching this file change the LDBL_PREC == 53 checks to i386 checks. The long double tests should only be disabled for i386 (due to the rather odd rounding mode that it uses) not all architectures where long double is the same as double. PR: 205449 Fixes: 87d65c747a43 ("lib/msun: Allow building tests with WARNS=6") Reported by: Jenkins (cherry picked from commit 7f5693d05329ab976287b8d449e694e7a0f99e88) --- lib/msun/tests/invtrig_test.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/msun/tests/invtrig_test.c b/lib/msun/tests/invtrig_test.c index 7dd8b26f652f..90ebcc5dfdad 100644 --- a/lib/msun/tests/invtrig_test.c +++ b/lib/msun/tests/invtrig_test.c @@ -68,7 +68,7 @@ __FBSDID("$FreeBSD$"); (tol) * ldexpf(1.0, 1 - FLT_MANT_DIG), (excepts)); \ } while (0) -#if LDBL_PREC == 53 +#ifdef __i386__ #define testall_tol _testall_tol #else #define testall_tol(prefix, x, result, tol, excepts) do { \ @@ -98,7 +98,7 @@ __FBSDID("$FreeBSD$"); (tol) * ldexpf(1.0, 1 - FLT_MANT_DIG), (excepts)); \ } while (0) -#if LDBL_PREC == 53 +#ifdef __i386__ #define testall2_tol _testall2_tol #else #define testall2_tol(prefix, y, x, result, tol, excepts) do { \ @@ -380,12 +380,14 @@ sinasin(double x) return (sinl(asin(x))); } +#ifndef __i386__ static long double sinasinl(long double x) { return (sinl(asinl(x))); } +#endif static long double cosacosf(float x) @@ -401,12 +403,14 @@ cosacos(double x) return (cosl(acos(x))); } +#ifndef __i386__ static long double cosacosl(long double x) { return (cosl(acosl(x))); } +#endif static long double tanatanf(float x) @@ -422,12 +426,14 @@ tanatan(double x) return (tanl(atan(x))); } +#ifndef __i386__ static long double tanatanl(long double x) { return (tanl(atanl(x))); } +#endif ATF_TC_WITHOUT_HEAD(inverse); ATF_TC_BODY(inverse, tc)