From owner-svn-ports-head@FreeBSD.ORG Sat Mar 1 14:46:15 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 116189CB; Sat, 1 Mar 2014 14:46:15 +0000 (UTC) Received: from mailrelay004.isp.belgacom.be (mailrelay004.isp.belgacom.be [195.238.6.170]) by mx1.freebsd.org (Postfix) with ESMTP id 5642B1DB1; Sat, 1 Mar 2014 14:46:13 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmMGALnxEVNR8Zjl/2dsb2JhbABagwa/IoMMgRIXdIIlAQEFOhweBRALGAklDyoeBogQActtF44EAQEcMweEOAEDmDuSLIMuO4E1 Received: from 229.152-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.152.229]) by relay.skynet.be with ESMTP; 01 Mar 2014 15:46:12 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.8/8.14.8) with ESMTP id s21Ek9ZN005799; Sat, 1 Mar 2014 15:46:10 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Sat, 1 Mar 2014 15:46:09 +0100 From: Tijl Coosemans To: "Adam Weinberger" Subject: Re: svn commit: r346570 - head/mail/squirrelmail Message-ID: <20140301154609.59b3897b@kalimero.tijl.coosemans.org> In-Reply-To: References: <201402281928.s1SJSOFd043779@svn.freebsd.org> <20140228205412.17dead83@kalimero.tijl.coosemans.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Mar 2014 14:46:15 -0000 On Fri, 28 Feb 2014 15:11:20 -0500 Adam Weinberger wrote: > On 28 Feb 2014, at 14:54, Tijl Coosemans wrote: >> On Fri, 28 Feb 2014 19:28:24 +0000 (UTC) Adam Weinberger wrote: >>> ${CHMOD} 730 ${STAGEDIR}${SQUIRRELDIR}/attach >>> ${CHMOD} 750 ${STAGEDIR}${SQUIRRELDIR}/data >> >> I think you can remove the chmod commands too... >> >> >>> Modified: head/mail/squirrelmail/pkg-plist >>> ============================================================================== >>> --- head/mail/squirrelmail/pkg-plist Fri Feb 28 19:14:42 >>> 2014 (r346569) >>> +++ head/mail/squirrelmail/pkg-plist Fri Feb 28 19:28:23 >>> 2014 (r346570) >>> @@ -1,5 +1,7 @@ >>> etc/periodic/daily/111.clean-squirrelmail >>> %%SQUIRRELDIR%%/attach/.htaccess >>> +@exec chown %%SMUSER%%:%%SMGROUP%% %B >>> +@exec chmod 730 %B >> >> ...if you do this as follows: >> >> @owner %%SMUSER%% >> @group %%SMGROUP%% >> @mode 730 >> %%SQUIRRELDIR%%/attach/.htaccess >> @owner >> @group >> @mode >> >> Are you sure that 3 for group permissions is correct? >> >>> +@exec chown %%SMUSER%%:%%SMGROUP%% %B >>> +@exec chmod 750 %B >> >> Same here, but you could also group it with the .htaccess file above. >> >> The pkg-plist format is explained in the pkg-create manpage by the >> way. > > %B refers to the dirname. Your suggestion would change the ownership and > permissions of the .htaccess file, which would then require an @exec > chown and @exec chmod to repair, so it wouldn't really fix anything. Ah, right. With pkg you can set permissions on a directory with @owner etc. around the @dirrm for that directory. That doesn't work with the old pkg_create but I think @exec chmod does, so you would have to use both these methods at the moment. The problem with the port now is that there's a window in which you give write permissions on a directory to the wrong group of users.