Date: Mon, 4 Dec 2023 09:37:24 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: Dries Michiels <driesm@freebsd.org> Cc: FreeBSD Net <freebsd-net@freebsd.org>, Konstantin Belousov <kib@freebsd.org> Subject: Re: mlx5 fails to attach after STABLE-14 source upgrade Message-ID: <FDC214C1-B700-4C4B-A1FB-FAF459BD5613@FreeBSD.org> In-Reply-To: <CACx_iRFX6RfvxB%2BGZHohsQKBGpBwkWDbWH4kiEZo7aJCt8GM9Q@mail.gmail.com> References: <CACx_iRFX6RfvxB%2BGZHohsQKBGpBwkWDbWH4kiEZo7aJCt8GM9Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_F8FB19B9-62B4-45BA-A76C-BFC2777C7AF3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Dec 2, 2023, at 3:29 AM, Dries Michiels <driesm@freebsd.org> wrote: >=20 > <image.png> >=20 > After updating my STABLE-14 machine from somewhere quite recently (my = old kernel that boots without error is from 14-n265716-bd7dceb27c08 = somewhere previous saturday). > The new kernel that didn't boot was from Commit = 24cd42aeb6232b4678f45dc6d242e8982dbea8e6 (HEAD -> stable/14, = origin/stable/14) checked out. >=20 > Could someone take a look at this? >=20 > Regards > Dries Hi Dries, The commit 24cd42aeb6232b4678f45dc6d242e8982dbea8e6 is for crypto/ossl , = that should not affect mlx5. There're some changes since bd7dceb27c08, ``` git log --format=3Doneline bd7dceb27c08..24cd42aeb623 -- sys/dev/mlx5 ac83e415ef083da400509c6fa434ee59cfe9668f mlx5_core: fix deadlock when = using RXTLS 8377dd1c9aeb7f4e42ec2679bb8913379d9c77e7 mlx5core: add linux/bitops.h = include for mlx5_ifc.h use of BIT() 588203bfbdc46073dc8b4515d31a6a9efe3d9a3c mlx5: Introduce new destination = type TABLE_TYPE d82618894153d0f53b272a0c76fd180658efbb41 mlx5ib: adjust for the = mlx5_create_auto_grouped_flow_table() interface change e073fccf14569f61b312078d0cee9a6f6eb17a37 mlx5: add ability to attach = flow counter to steering rule 52164cb3bd38ef23c108149e4a91042da204a2f3 mlx5: add fs_counters 5a2ff1f03ad245577498bcbc3907f4ae336fd9e8 mlx5: Add a no-append flow = insertion mode 67a9c8868af371f3e0b96a18d1f9d54fd2be4b1a net/mlx5: Allow creating = autogroups with reserved entries 4c6a46cea41b236f9b06e702e8491055dddc7d4c net/mlx5: Fix auto group size = calculation 0759f76e579d61e4609b05ea0efcc2d1a63d2679 mlx5: Use software enum in APIs = instead of PRM 6fb2eebf6471ee08949dd027a6beffdbf78d8bb1 mlx5: Add packet reformat = support to flow rules 8895a0509698f29bb234a186590e3f08970a34d9 mlx5: Add modify header support = to flow rules 08e7b322db02329516e5d8adcec9df3c7b20774c mlx5: Refactor flow actions = into a struct 87d86f3733a4cdfb5777bc2b28bd11db93c7ab97 mlx5: Add packet reformat = allocation support 2b729c222d4821069c817c853f56826d065f7ac7 mlx5: Add modify header support ``` You may want to revert part(s) of them to check which one is to be = blamed. You can build the driver module only, that should be quite fast. Best regards, Zhenlei --Apple-Mail=_F8FB19B9-62B4-45BA-A76C-BFC2777C7AF3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dus-ascii"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><div = dir=3D"auto" style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; = line-break: after-white-space;" class=3D""><br class=3D""><div><br = class=3D""><blockquote type=3D"cite" class=3D""><div class=3D"">On Dec = 2, 2023, at 3:29 AM, Dries Michiels <<a = href=3D"mailto:driesm@freebsd.org" class=3D"">driesm@freebsd.org</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div = dir=3D"ltr" class=3D""><div dir=3D"ltr" class=3D""><div dir=3D"ltr" = class=3D""><div dir=3D"ltr" class=3D""><span = id=3D"cid:ii_lpn0kxzi0"><image.png></span><br class=3D""><div = class=3D""><br class=3D""></div><div class=3D"">After updating my = STABLE-14 machine from somewhere quite recently (my old kernel that = boots without error is from 14-n265716-bd7dceb27c08 somewhere = previous saturday).<br class=3D""></div><div class=3D"">The new kernel = that didn't boot was from Commit = 24cd42aeb6232b4678f45dc6d242e8982dbea8e6 (HEAD -> stable/14, = origin/stable/14) checked out.</div><div class=3D""><br = class=3D""></div><div class=3D"">Could someone take a look at = this?</div><div class=3D""><br class=3D""></div><div = class=3D"">Regards</div><div = class=3D"">Dries</div></div></div></div></div> </div></blockquote></div><div class=3D""><br class=3D""></div><div = class=3D"">Hi Dries,</div><div class=3D""><br class=3D""></div><div = class=3D"">The commit <span style=3D"caret-color: rgb(0, 0, 0); = color: rgb(0, 0, 0);" class=3D"">24cd42aeb6232b4678f45dc6d242e8982dbea8e6 = is for </span><font color=3D"#000000" class=3D""><span = style=3D"caret-color: rgb(0, 0, 0);" class=3D"">crypto/ossl , that = should</span></font></div><div class=3D""><font color=3D"#000000" = class=3D""><span style=3D"caret-color: rgb(0, 0, 0);" class=3D"">not = affect mlx5.</span></font></div><div dir=3D"auto" style=3D"word-wrap: = break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" = class=3D""><br class=3D""></div><div dir=3D"auto" style=3D"word-wrap: = break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" = class=3D"">There're some changes since bd7dceb27c08,</div><div = dir=3D"auto" style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; = line-break: after-white-space;" class=3D"">```</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">git log --format=3Doneline = bd7dceb27c08..24cd42aeb623 -- sys/dev/mlx5</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D""><br class=3D""></div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D""><div dir=3D"auto" style=3D"word-wrap: = break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" = class=3D"">ac83e415ef083da400509c6fa434ee59cfe9668f mlx5_core: fix = deadlock when using RXTLS</div><div dir=3D"auto" style=3D"word-wrap: = break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" = class=3D"">8377dd1c9aeb7f4e42ec2679bb8913379d9c77e7 mlx5core: add = linux/bitops.h include for mlx5_ifc.h use of BIT()</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">588203bfbdc46073dc8b4515d31a6a9efe3d9a3c = mlx5: Introduce new destination type TABLE_TYPE</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">d82618894153d0f53b272a0c76fd180658efbb41 = mlx5ib: adjust for the mlx5_create_auto_grouped_flow_table() interface = change</div><div dir=3D"auto" style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" = class=3D"">e073fccf14569f61b312078d0cee9a6f6eb17a37 mlx5: add ability to = attach flow counter to steering rule</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">52164cb3bd38ef23c108149e4a91042da204a2f3 = mlx5: add fs_counters</div><div dir=3D"auto" style=3D"word-wrap: = break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" = class=3D"">5a2ff1f03ad245577498bcbc3907f4ae336fd9e8 mlx5: Add a = no-append flow insertion mode</div><div dir=3D"auto" style=3D"word-wrap: = break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" = class=3D"">67a9c8868af371f3e0b96a18d1f9d54fd2be4b1a net/mlx5: Allow = creating autogroups with reserved entries</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">4c6a46cea41b236f9b06e702e8491055dddc7d4c = net/mlx5: Fix auto group size calculation</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">0759f76e579d61e4609b05ea0efcc2d1a63d2679 = mlx5: Use software enum in APIs instead of PRM</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">6fb2eebf6471ee08949dd027a6beffdbf78d8bb1 = mlx5: Add packet reformat support to flow rules</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">8895a0509698f29bb234a186590e3f08970a34d9 = mlx5: Add modify header support to flow rules</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">08e7b322db02329516e5d8adcec9df3c7b20774c = mlx5: Refactor flow actions into a struct</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">87d86f3733a4cdfb5777bc2b28bd11db93c7ab97 = mlx5: Add packet reformat allocation support</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">2b729c222d4821069c817c853f56826d065f7ac7 = mlx5: Add modify header support</div></div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">```</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D""><br class=3D""></div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">You may want to revert part(s) of them to = check which one is to be blamed.</div><div dir=3D"auto" = style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break: = after-white-space;" class=3D"">You can build the driver module only, = that should be quite fast.</div><br class=3D""><div class=3D""> <div>Best regards,</div><div>Zhenlei</div> </div> <br class=3D""></div></body></html>= --Apple-Mail=_F8FB19B9-62B4-45BA-A76C-BFC2777C7AF3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FDC214C1-B700-4C4B-A1FB-FAF459BD5613>