From owner-freebsd-multimedia@freebsd.org Fri May 31 13:01:53 2019 Return-Path: Delivered-To: freebsd-multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9B7715BD039 for ; Fri, 31 May 2019 13:01:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 7A2746C480 for ; Fri, 31 May 2019 13:01:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 38DC815BD037; Fri, 31 May 2019 13:01:52 +0000 (UTC) Delivered-To: multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 260EE15BD036 for ; Fri, 31 May 2019 13:01:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B51E36C47D for ; Fri, 31 May 2019 13:01:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id EBB8911CB2 for ; Fri, 31 May 2019 13:01:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x4VD1oAD021127 for ; Fri, 31 May 2019 13:01:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x4VD1omC021126 for multimedia@FreeBSD.org; Fri, 31 May 2019 13:01:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: maintainer-feedback requested: [Bug 238261] multimedia/vlc: fixes undeclared dependencies Date: Fri, 31 May 2019 13:00:55 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: multimedia@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 May 2019 13:01:53 -0000 Bugzilla Automation has asked freebsd-multimedia mai= ling list for maintainer-feedback: Bug 238261: multimedia/vlc: fixes undeclared dependencies https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238261 --- Description --- Compiling the port with DEVELOPER=3Dyes revealed some implicit dependencies. Using poudriere I tried to spot all of them and fix them. Here is a short description of the patch: - Adds security/libgpg-error and textproc/libebml to LIB_DEPENDS. - Defines three new options -- GSTREAMER, JPEG, OGGSPOTS -- enabled by defa= ult. Those are necessary because otherwise the configure script will automatical= ly choose if enabling the corresponding features or not, making dependencies difficult to track. - Adds USE_GNOME=3Dcairo when LIBSVG2 is on or NOTIFY is on. - Adds SDL_USES=3Dsdl since USE_SDL alone is deprecated. - Adds dependency on audio/speexdsp when SPEEX is on. - Adds VDPAU_USE=3D XORG=3Dsm,ice,x11. - Bumps PORTREVISION. Tested successfully with poudriere on 12.0-RELEASE amd64, but since the port has many options and my macchine is slow, I could not test all cases and I suggest to test it more.