From owner-cvs-src@FreeBSD.ORG Sat Oct 28 07:42:26 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2794216A40F; Sat, 28 Oct 2006 07:42:26 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (vlsi00.si.noda.tus.ac.jp [133.31.130.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B62A43D45; Sat, 28 Oct 2006 07:42:25 +0000 (GMT) (envelope-from hrs@FreeBSD.org) Received: from delta.allbsd.org (p3098-ipbf401funabasi.chiba.ocn.ne.jp [124.86.53.98]) (authenticated bits=128) by mail.allbsd.org (8.13.1/8.13.4) with ESMTP id k9S7gC6o014772; Sat, 28 Oct 2006 16:42:23 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (alph.allbsd.org [192.168.0.10]) (authenticated bits=0) by delta.allbsd.org (8.13.4/8.13.4) with ESMTP id k9S7fkdO039476; Sat, 28 Oct 2006 16:41:49 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sat, 28 Oct 2006 16:41:40 +0900 (JST) Message-Id: <20061028.164140.102116870.hrs@allbsd.org> To: jfvogel@gmail.com From: Hiroki Sato In-Reply-To: <2a41acea0610280019r15d1e40bgbec37d9e0f72633e@mail.gmail.com> References: <200610280137.k9S1bFq2089275@repoman.freebsd.org> <20061028.161036.78701604.hrs@allbsd.org> <2a41acea0610280019r15d1e40bgbec37d9e0f72633e@mail.gmail.com> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 5.1 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sat_Oct_28_16_41_40_2006_504)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.88.2, clamav-milter version 0.88.2 on gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (mail.allbsd.org [133.31.130.32]); Sat, 28 Oct 2006 16:42:24 +0900 (JST) Cc: jfv@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h if_em_osdep.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2006 07:42:26 -0000 ----Security_Multipart(Sat_Oct_28_16_41_40_2006_504)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit "Jack Vogel" wrote in <2a41acea0610280019r15d1e40bgbec37d9e0f72633e@mail.gmail.com>: jf> On 10/28/06, Hiroki Sato wrote: jf> > Jack F Vogel wrote jf> > in <200610280137.k9S1bFq2089275@repoman.freebsd.org>: jf> > jf> > jf> jfv 2006-10-28 01:37:14 UTC jf> > jf> jf> > jf> FreeBSD src repository jf> > jf> jf> > jf> Modified files: (Branch: RELENG_6) jf> > jf> sys/dev/em if_em.c if_em.h if_em_hw.c if_em_hw.h jf> > jf> if_em_osdep.h jf> > jf> Log: jf> > jf> Merge of Intel 6.2.9 em driver code. jf> > jf> Approved by: re, scottl, jhb, pdeuskar jf> > jf> jf> > jf> Revision Changes Path jf> > jf> 1.65.2.19 +731 -589 src/sys/dev/em/if_em.c jf> > jf> 1.32.2.5 +97 -71 src/sys/dev/em/if_em.h jf> > jf> 1.16.2.4 +574 -531 src/sys/dev/em/if_em_hw.c jf> > jf> 1.15.2.5 +96 -148 src/sys/dev/em/if_em_hw.h jf> > jf> 1.14.2.3 +46 -52 src/sys/dev/em/if_em_osdep.h jf> > jf> > Just wanted to make sure, but is the following change in if_em.c jf> > really intentional? This means that the new version no longer jf> > supports 82542... jf> > jf> > Index: if_em.c jf> > @@ -116,8 +117,6 @@ jf> > { 0x8086, E1000_DEV_ID_82541GI_LF, PCI_ANY_ID, PCI_ANY_ID, 0}, jf> > { 0x8086, E1000_DEV_ID_82541GI_MOBILE, PCI_ANY_ID, PCI_ANY_ID, 0}, jf> > jf> > - { 0x8086, E1000_DEV_ID_82542, PCI_ANY_ID, PCI_ANY_ID, 0}, jf> > - jf> > { 0x8086, E1000_DEV_ID_82543GC_FIBER, PCI_ANY_ID, PCI_ANY_ID, 0}, jf> > { 0x8086, E1000_DEV_ID_82543GC_COPPER, PCI_ANY_ID, PCI_ANY_ID, 0}, jf> jf> Yes that was intentional, its an ID that the Intel source has not jf> had for some time. When I put it back in our source a while back jf> due to a merge our test group came to me and said these adapters jf> dont even work with the driver, so clearly no one is using them :) jf> jf> I asked about dropping the ID to a set of developers and got the OK to drop jf> it. jf> jf> If someone actually speaks up about having hardware that was working and jf> now is broken I'll take it all back and we can put the ID back in, is that good jf> enough? :) So here is the report (from nyan@): em0@pci1:1:0: class=0x020000 card=0x10008086 chip=0x10008086 rev=0x03 hdr=0x00 vendor = 'Intel Corporation' device = '82542 Gigabit Ethernet Controller' class = network subclass = ethernet It is not recognized by the new driver at boot time while worked fine with the old one. I think we should not remove the existing hardware support (especially in -STABLE) if possible. -- | Hiroki SATO ----Security_Multipart(Sat_Oct_28_16_41_40_2006_504)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBFQwm0TyzT2CeTzy0RAnLLAJ9PhxxczQY/tGdazIx56Kx+LfU5hQCfeQJi GUoghxqg1pYh/SJD3WQ23go= =7uEI -----END PGP SIGNATURE----- ----Security_Multipart(Sat_Oct_28_16_41_40_2006_504)----