From owner-cvs-ports@FreeBSD.ORG  Fri Mar  5 13:38:54 2010
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9B51B106566C;
	Fri,  5 Mar 2010 13:38:54 +0000 (UTC) (envelope-from tobez@tobez.org)
Received: from heechee.tobez.org (heechee.tobez.org [194.255.56.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 5ACEE8FC14;
	Fri,  5 Mar 2010 13:38:54 +0000 (UTC)
Received: by heechee.tobez.org (Postfix, from userid 1001)
	id 3B6DD6D400; Fri,  5 Mar 2010 14:38:53 +0100 (CET)
Date: Fri, 5 Mar 2010 14:38:53 +0100
From: Anton Berezin <tobez@tobez.org>
To: wen heping <wenheping@gmail.com>
Message-ID: <20100305133853.GD7708@heechee.tobez.org>
Mail-Followup-To: Anton Berezin <tobez@tobez.org>,
	wen heping <wenheping@gmail.com>, Wen Heping <wen@freebsd.org>,
	ports-committers@freebsd.org, cvs-ports@freebsd.org,
	cvs-all@freebsd.org
References: <201003050042.o250gscP075349@repoman.freebsd.org>
	<20100305091220.GB7708@heechee.tobez.org>
	<7be7a2801003050454m3258b2aandca5cc60195d9d9a@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7be7a2801003050454m3258b2aandca5cc60195d9d9a@mail.gmail.com>
X-Powered-By: FreeBSD http://www.freebsd.org/
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: Wen Heping <wen@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: cvs commit: ports/devel/p5-Make-Cache Makefile distinfo
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Mar 2010 13:38:54 -0000

On Fri, Mar 05, 2010 at 08:54:31PM +0800, wen heping wrote:
> On Fri, Mar 5, 2010 at 5:12 PM, Anton Berezin <tobez@tobez.org> wrote:
> > On Fri, Mar 05, 2010 at 12:42:54AM +0000, Wen Heping wrote:
> >> wen         2010-03-05 00:42:54 UTC
> >>
> >>   FreeBSD ports repository
> >>
> >>   Modified files:
> >>     devel/p5-Make-Cache  Makefile distinfo
> >>   Log:
> >>   - Update to 1.052
> >>
> >>   Feature safe:   yes
> >
> > In my tests, this version failed its own regression tests under either one
> > of the following two conditions: when a recent p5-Storable is installed, or
> > when using perl 5.10.1.  I suspect that in practice this is the same
> > condition, since the version of Storable.pm supplied with perl 5.10.1 (2.20)
> > is more recent than the version of Storable.pm installed with perl 5.8.9
> > (2.19).
> >
> > I understand that it is not realistic to expect that you would test it with
> > and without p5-Storable installed.  On the other hand, at the very least, I
> > would expect that 1) the distribution tests are run before commit, and 2)
> > they are run with *both* lang/perl5.8 and lang/perl5.10.
> 
> Yes, the regression test failed.   :(
> 
> Can we make bsd.perl.mk support "make test" ?

While it would be useful, is it really needed?

   ( cd `make -V WRKSRC` ; make test )

works just as well, not even mentioning all sorts of possible automation of
the building and testing process.

Cheers,
\Anton.
-- 
Matters of elegance ought to be left to the tailor and to the cobbler.
  -- L. Boltzmann