From owner-freebsd-geom@FreeBSD.ORG  Fri Apr  8 05:42:03 2005
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 766A516A4CF; Fri,  8 Apr 2005 05:42:03 +0000 (GMT)
Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B84FB43D48; Fri,  8 Apr 2005 05:42:02 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.3/8.13.1) with ESMTP id j385g1oK023987;
	Fri, 8 Apr 2005 07:42:01 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Pawel Jakub Dawidek <pjd@freebsd.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Fri, 08 Apr 2005 01:44:24 +0200."
             <20050407234424.GV837@darkness.comp.waw.pl> 
Date: Fri, 08 Apr 2005 07:42:01 +0200
Message-ID: <23986.1112938921@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: freebsd-geom@freebsd.org
Subject: Re: Bug in geom_ctl errors handling. 
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Apr 2005 05:42:03 -0000


Good catch, go for it!

In message <20050407234424.GV837@darkness.comp.waw.pl>, Pawel Jakub Dawidek writes:
>
>--VnCKLxguT6BBzdXa
>Content-Type: text/plain; charset=iso-8859-2
>Content-Disposition: inline
>Content-Transfer-Encoding: quoted-printable
>
>Hi.
>
>I finally tracked down a bug which I was seeing from time to time.
>If you saw 'Bad address' as an result of some geom(8) command, you saw
>the bug.
>
>The problem we got here, is that copyout(9) was done not from user
>process, but from eg. g_event thread, where address space is different.
>
>Here is the patch to fix it:
>
>	http://people.freebsd.org/~pjd/patches/geom_ctl.c.patch
>
>--=20
>Pawel Jakub Dawidek                       http://www.wheel.pl
>pjd@FreeBSD.org                           http://www.FreeBSD.org
>FreeBSD committer                         Am I Evil? Yes, I Am!
>
>--VnCKLxguT6BBzdXa
>Content-Type: application/pgp-signature
>Content-Disposition: inline
>
>-----BEGIN PGP SIGNATURE-----
>Version: GnuPG v1.2.4 (FreeBSD)
>
>iD8DBQFCVcXYForvXbEpPzQRAsppAJ4iNhocWjPLVQ33ps1EB0RSr7HpcACdE7Gj
>40Xe83iHSVkAA8Gm8JAjizg=
>=H7Kc
>-----END PGP SIGNATURE-----
>
>--VnCKLxguT6BBzdXa--
>

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.