From owner-svn-src-all@freebsd.org Tue Sep 1 13:34:57 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 46DEA3C8351; Tue, 1 Sep 2020 13:34:57 +0000 (UTC) (envelope-from meloun.michal@gmail.com) Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bgp344JxMz4WlK; Tue, 1 Sep 2020 13:34:56 +0000 (UTC) (envelope-from meloun.michal@gmail.com) Received: by mail-ed1-x543.google.com with SMTP id w1so1463879edr.3; Tue, 01 Sep 2020 06:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Stn48hCWgLrDcv67QKeJOCnXn0r27cybTo6KUMrdrEI=; b=SLKJiYp5AU8SkKCHGr4KbspPvuq3n27kWrrSxu/NB3xv7QTpK6ttvZYokAhgNbqtMv s2wTIcN7kn6bM16VpPWD2p7CQDNo0Zz5Cw9VNjW5OZmM9R61p8C0kA3Z/aGjHs85UQVP LFpDjA1kpQZsl7/kGYy609vdoqw9aYguXdK+yi2TPQgV8u+KewISprO7zcRrzbmaZrFV OqOSV0SXCNroahr/l6OeiiOEpJS3G2iWTGk7u4YGkEn9gYB+maU58SdCWrkN7aMOgWcA 6Cqf+r+3w/+YPmeCwYxygWgdlGn3vIv9g1kkjv4kxJhgRHw2PqAcaEZ7KvCsjphTPkLf 2xaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Stn48hCWgLrDcv67QKeJOCnXn0r27cybTo6KUMrdrEI=; b=dys1l00uoJMxab2wkmdjgnX9T/2jnhP/9EWc+iwhq5W9HDSl/MZxaLE4JEtdwvQ2dC VDh0UL0KlGNbD0a7Bwv2fYAFQnzdOM0yyBDgmzmafs1hzzg91xUrVQQecX9mMUOyru90 hwYjjHrfRiG25V+ienO7i5RTXxrBGEc7Pmwb6G18/x0gtEE/y0hs31wyzfw8iWlBPu2O eS7M4GD1ZQFInWcn5CPtwykGElUVXksPBkKHb8mQhI495xovw4yzg4DnNOoYRr7lz4ze Z9aigF0aZ9JinUo4+ncRGe363qzxKNfP/8kc3ax6eBwWc0a6JPZPrkMLOEwVEGNjK+h1 aIfQ== X-Gm-Message-State: AOAM5332qE3RvDEaZpVDHrmqvPU8ZoL9sfLIkx24qLFr+GraY3LP0JBA llVUK1KbkPI3qr7C6ThRTgXHVRC5MnsaLA== X-Google-Smtp-Source: ABdhPJw6yrxEQu3ivPUlsfWTUbsOa4MFuRkH4JnF0hM5QYogSH5yYwZBrRrKFUCHWlqRPmxH7+uLxw== X-Received: by 2002:a05:6402:6d6:: with SMTP id n22mr1711023edy.79.1598967294985; Tue, 01 Sep 2020 06:34:54 -0700 (PDT) Received: from [88.208.79.100] (halouny.humusoft.cz. [88.208.79.100]) by smtp.gmail.com with ESMTPSA id mb16sm1287652ejb.45.2020.09.01.06.34.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2020 06:34:54 -0700 (PDT) Sender: Michal Meloun Reply-To: meloun.michal@gmail.com Subject: Re: svn commit: r364737 - head/sys/dev/drm2 To: Emmanuel Vadot Cc: Niclas Zeising , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202008242253.07OMrNO2016612@repo.freebsd.org> <790db2ea-0877-671e-e48f-ec6da42c7437@gmail.com> <20200901151635.91c121acb2bf58e9282aa6ae@bidouilliste.com> From: Michal Meloun Message-ID: <6ce33c1a-a268-dbaa-a434-e4769827b168@gmail.com> Date: Tue, 1 Sep 2020 15:34:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200901151635.91c121acb2bf58e9282aa6ae@bidouilliste.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Bgp344JxMz4WlK X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=SLKJiYp5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of melounmichal@gmail.com designates 2a00:1450:4864:20::543 as permitted sender) smtp.mailfrom=melounmichal@gmail.com X-Spamd-Result: default: False [-4.20 / 15.00]; HAS_REPLYTO(0.00)[meloun.michal@gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.16)[-1.161]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.02)[-1.020]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.02)[-1.021]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_REPLYTO(0.00)[gmail.com]; REPLYTO_DOM_EQ_FROM_DOM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::543:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-head,svn-src-all] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2020 13:34:57 -0000 On 01.09.2020 15:16, Emmanuel Vadot wrote: > On Tue, 1 Sep 2020 15:13:53 +0200 > Michal Meloun wrote: > >> >> >> On 25.08.2020 0:53, Niclas Zeising wrote: >>> Author: zeising (doc,ports committer) >>> Date: Mon Aug 24 22:53:23 2020 >>> New Revision: 364737 >>> URL: https://svnweb.freebsd.org/changeset/base/364737 >>> >>> Log: >>> drm2: Update deprecation message >>> >>> Update the deprecation message in the drm2 (aka legacy drm) drivers to point >>> towards the graphics/drm-kmod ports for all architectures, not just amd64. >> Only known user of drm2 is arm/tegra124 based boards. How >> graphics/drm-kmod can help for these? >> Or be more specific - drm2 allows me to hot-plug monitor to tegra based >> board an use 2 scaled overlay planes (which is exactly whats I want for >> my application). Which alternative can you offer me? >> Btw, as you can see, the maintenance cost of drm2 is close to zero and >> the dev/drm2 code does not inherit with any of the major architectures. >> >> Michal > > I think that the goal was only to mfc this to warn users before 12.2 > is branched, maybe a direct commit to 12 would have been better. > My main concern is #ifdef removal (thus expanding the removal message also on QARM). I understand that drm2 code is very old, but it works, is used, and have very minimal impact on other architectures or rest of kernel. Within these conditions, I don't see single reason to remove (on ARM) drm2 code in 13. >> >>> drm-kmod has support for more architectures these days, and the >>> graphics/drm-legacy-kmod port is being deprecated. >> >>> >>> Approved by: imp >>> MFC after: 1 week >>> Differential Revision: https://reviews.freebsd.org/D26174 >>> >>> Modified: >>> head/sys/dev/drm2/drm_os_freebsd.h >>> >>> Modified: head/sys/dev/drm2/drm_os_freebsd.h >>> ============================================================================== >>> --- head/sys/dev/drm2/drm_os_freebsd.h Mon Aug 24 22:48:19 2020 (r364736) >>> +++ head/sys/dev/drm2/drm_os_freebsd.h Mon Aug 24 22:53:23 2020 (r364737) >>> @@ -154,16 +154,12 @@ typedef void irqreturn_t; >>> *(volatile u_int64_t *)(((vm_offset_t)(map)->handle) + \ >>> (vm_offset_t)(offset)) = htole64(val) >>> >>> -#ifdef amd64 >>> #define DRM_PORT "graphics/drm-kmod" >>> -#else >>> -#define DRM_PORT "graphics/drm-legacy-kmod" >>> -#endif >>> >>> #define DRM_OBSOLETE(dev) \ >>> do { \ >>> device_printf(dev, "=======================================================\n"); \ >>> - device_printf(dev, "This code is obsolete abandonware. Install the " DRM_PORT " pkg\n"); \ >>> + device_printf(dev, "This code is deprecated. Install the " DRM_PORT " pkg\n"); \ >>> device_printf(dev, "=======================================================\n"); \ >>> gone_in_dev(dev, 13, "drm2 drivers"); \ >>> } while (0) >>> > >