From owner-freebsd-current Thu Jul 30 01:33:57 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA00467 for freebsd-current-outgoing; Thu, 30 Jul 1998 01:33:57 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA00458 for ; Thu, 30 Jul 1998 01:33:50 -0700 (PDT) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id SAA05989; Thu, 30 Jul 1998 18:33:38 +1000 Date: Thu, 30 Jul 1998 18:33:38 +1000 From: Bruce Evans Message-Id: <199807300833.SAA05989@godzilla.zeta.org.au> To: current@FreeBSD.ORG, luoqi@chen.ml.org Subject: Re: using vm_page.h in userland program Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG >Recent change (addition of cache coloring) to vm/vm_page.h has made it >impossible to use this header file in a userland program. It tries to >include "opt_vmpage.h" unconditionally. IMO, "opt_vmpage.h" should only >be included when KERNEL is defined. Would someone please make the change? Cache coloring isn't recent, but new-style options for it are recent. The options should not have been made new-style, since including options headers in other headers doesn't work well. Of course, old-style options in headers don't work well either - there is no way to tell if the ifdefed options in the header were actually used. I looked at moving the options to vm_page.c. IIRC, the only problem was that a couple of extern arrays have size depending on the options. Perhaps these arrays can be declared without a size. The cache coloring options should be dynamic anyway. I have tried a few different values on various machines but didn't notice much difference and didn't have time to do careful comparisons. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message