From owner-cvs-ports@FreeBSD.ORG Wed May 2 03:06:04 2012 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3EA14106566B for ; Wed, 2 May 2012 03:06:04 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 055478FC0A for ; Wed, 2 May 2012 03:06:03 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so411057pbb.13 for ; Tue, 01 May 2012 20:06:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to:x-operating-system:organization :x-living-the-dream:x-pgp-fingerprint:x-pgp-key:user-agent :x-gm-message-state; bh=i5LWYpWfUZJHWN9EC0NtsXhBi/ISUNZ+Szj1k/SXK9A=; b=CiSnrii77ZB/Z151Qx0N/t6WiJ5Vb5rBwh86PN5vaLQsqNu8wNtns7WF9dgCw40Zxk mlGyl1/a1d6Al9JWmiwUQWVnKWs2288hId7BAsbigvYyxH67IbPZAqCsBLhxkTRTuFaJ DhI6mYOpvfsdFMhhNI03R0l8bYVgSlGPp8QGD6vm2tgNqHuTS70yJnDrqAFeIhnWo4ic 0nPyl2u4s2yTy6fx/BW8QVzsn/FslZr+6u+LtXgGukuK/2HHyrTzHmBrfTEO95v0Ulvz UthVX3hb0HV/0c1nDmF0FHEs89WF7ICe4iNNrvuBmtKGI5oUWF9HCBgeG4OGxBpOCToe N7aA== Received: by 10.68.217.201 with SMTP id pa9mr27538611pbc.73.1335927963268; Tue, 01 May 2012 20:06:03 -0700 (PDT) Received: from dormouse.experts-exchange.com ([72.29.164.238]) by mx.google.com with ESMTPS id og6sm622116pbb.42.2012.05.01.20.06.01 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 01 May 2012 20:06:02 -0700 (PDT) Sender: Jason Helfman Date: Tue, 1 May 2012 20:04:53 -0700 From: Jason Helfman To: Michael Scheidell Message-ID: <20120502030453.GA33262@dormouse.experts-exchange.com> References: <201205011910.q41JA1g4058443@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; x-action=pgp-signed In-Reply-To: <201205011910.q41JA1g4058443@repoman.freebsd.org> X-Operating-System: FreeBSD 8.3-RELEASE amd64 Organization: The FreeBSD Project, http://www.freebsd.org X-Living-The-Dream: I love the SLO Life! X-PGP-FingerPrint: 8E0D C457 9A0F C91C 23F3 0454 2059 9A63 4150 D3DC X-PGP-Key: http://people.freebsd.org/~jgh/jgh.asc User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQn0/zynC+p1fZbU+pyxOoqeOsA/ff+S0lSICWaZMnCC4sMdB988VZrdD2J5rpUqTrdlIz8x Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/gwenhywfar pkg-plist ports/finance/aqbanking pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2012 03:06:04 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, May 01, 2012 at 07:10:01PM +0000, Michael Scheidell thus spake: >scheidell 2012-05-01 19:10:01 UTC > > FreeBSD ports repository > > Modified files: > devel/gwenhywfar pkg-plist > finance/aqbanking pkg-plist > Log: > - Revert %%DATADIR%% changes to pkg-plists. Application is not DATADIR safe > - No PORTREVISION bump since the defaults do not change package > > PR: ports/167461 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=167461 > Submitted by: Jason E. Hale (maintainer) > > Revision Changes Path > 1.15 +26 -26 ports/devel/gwenhywfar/pkg-plist > 1.18 +154 -154 ports/finance/aqbanking/pkg-plist > >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/devel/gwenhywfar/pkg-plist.diff?&r1=1.14&r2=1.15&f=h >http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/finance/aqbanking/pkg-plist.diff?&r1=1.17&r2=1.18&f=h > For the record, this did not break anything, and if anything, it is breaking some of the rules for installation, as it installs portdata outside of the portname, itself, in addition to the its' own portname directory inside the default DATADIR. All of this aside, the only place I have seen this reference to "DATADIR safe" is portlint. I have not seen it in bpm, or in the handbook. If portlint is correct, we need to update the other documentation to support it. To the point if it is unsafe -- every port that uses this, is then unsafe, and should be fixed. Beyond this, why not make it DATADIR safe, if there is an unsafe, for all applications by removing the configrability of it. Is there any reason that portdata should be installed elsewhere? In closing, if there is an unsafe, why are we supporting anything that is unsafe? Thanks. - -jgh - -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBAgAGBQJPoKRVAAoJECBZmmNBUNPcNcsH/1zZEZjqLhiXtIwFMs2SSJ5/ 9yYmfdwHsf5e1AlM4qNQoNEwdnIDDVvt3dYH8Twvu4ZMF2EaSBjf9dq0ZFiy7Og0 +9B0tipkfHGpG5ebq3Yj1vaZyfnGmaCtCd1nYXx1hYCz1uNFl2ffVoV1DSlwQY7Y oNqms2j/btxDTNM+zJzKgiyGgjLePr+5FkwpGVyfa2iRuZ6mNH9xjKSo0Wf6i32N WqOiVgudaq5V8pl3NAg8pjA2FBej8yvmzMM5QaxEvArowuRrn5Rfcnk0DP14pmdH P+OT1+SPlpoeuWPfGZrNLr7xuH80x2CIHtSqhWgziG8MRsWUnb3VyS5apXwoLks= =x9jJ -----END PGP SIGNATURE-----