From owner-svn-ports-all@freebsd.org Sat Dec 14 00:47:56 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DBFC21DB91F; Sat, 14 Dec 2019 00:47:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47ZTQz5N0Jz3Fs3; Sat, 14 Dec 2019 00:47:55 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x530.google.com with SMTP id 6so314765pgk.0; Fri, 13 Dec 2019 16:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CUYXhc+MkJBpRTNRWpRmaecw08Sk/Dl5F0Rd84UG+vY=; b=FoqGyxACFAHrIBRJQupiq04ejw4ArZRMhzJ8yghMP0nboWEwRYc4nGVQcFNPB7yG4q xtTPCGoX3r/9wYZBz96yzOYfNjHBx5NGAcx54KrucIJNK/QvsvZ0fepBz2HQJWhVVmVs OYjjWgUMAjm5CvYyUUlm+yk+y0ZcmSpzQPpvILukdF8eubIsDadWidUPShbzE0CubiZk WpGTvBf5vfPUrmsYgYJhU/yiCB4EFQsPQGQ5F9eHq7UERLxtHFGF599RhypdlkSOfZ8Q AfD7UzF+/uwfClzVCaeG1dmzuG4N6o+lrnJ0A7icx+ylW/OVIDvssWPmdoMOkvhMr+fh zF2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=CUYXhc+MkJBpRTNRWpRmaecw08Sk/Dl5F0Rd84UG+vY=; b=SkxKwM0+EQaGRoWBtzFs+LYwL/PUXLZJt3rq8o3bFhormOA5tayR6IG4StdvC/VXbW TqIsk1H86CHQ//P5aV+w5tn9JAgmYqE7HSa9Mzd+Xss2VQ0cVAU1QNjdMbhizvv6tUZ+ 36/JxXi4kNc+FPvKdrwY+pI2WyXLK/tjXOEiDU9gfSpXl0B7frqmKO+Tq7+DuU8axXwt aISlURdsDGdIsZlcmnP9QttuGHKapYhftDMXrE7EhgX3JrJKY2nwwELTv0rs7RfC1Q7N uQrvRm2MCsriocxagEekXJmXD0IJD9PoEtyKpOmh6lJmtf/bSovUBdU3xrLFEcUCQf6s icAg== X-Gm-Message-State: APjAAAVAu4aZf9hyNmAoTcUu9nLFxm8XMqcgu6EYy2LVCVfTmeIdnq/K E64m5x9AHbKalRjJlyHH3IER69UL X-Google-Smtp-Source: APXvYqzmITVjGqP8Ml7Y8mCWBbsBNwYlazgtO3RCN4uSsbTdQPvHbtd/P7hxypqwYdS+32vVoQgdXA== X-Received: by 2002:a62:7541:: with SMTP id q62mr2644869pfc.256.1576284473982; Fri, 13 Dec 2019 16:47:53 -0800 (PST) Received: from [192.168.1.110] (180-150-68-130.b49644.syd.nbn.aussiebb.net. [180.150.68.130]) by smtp.gmail.com with ESMTPSA id y22sm12868390pfn.122.2019.12.13.16.47.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Dec 2019 16:47:53 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r520074 - head/ftp/curl To: Jan Beich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201912140013.xBE0DB77036746@repo.freebsd.org> From: Kubilay Kocak Message-ID: <67545a34-c13d-523f-ebe9-111a86117bd7@FreeBSD.org> Date: Sat, 14 Dec 2019 11:47:49 +1100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Thunderbird/72.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47ZTQz5N0Jz3Fs3 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=FoqGyxAC; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::530 as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-4.85 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; IP_SCORE(-2.65)[ip: (-9.10), ipnet: 2607:f8b0::/32(-2.20), asn: 15169(-1.91), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; RCVD_IN_DNSWL_NONE(0.00)[0.3.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Dec 2019 00:47:56 -0000 On 14/12/2019 11:33 am, Jan Beich wrote: > Kubilay Kocak writes: > >> -OPTIONS_DEFAULT= ALTSVC CA_BUNDLE COOKIES GSSAPI_${${SSL_DEFAULT} == base :?BASE :NONE} DICT FTP GOPHER HTTP HTTP2 IMAP OPENSSL POP3 PROXY RESOLV RTSP SMTP TELNET TFTP THREADED_RESOLVER TLS_SRP >> +OPTIONS_DEFAULT= ALTSVC CA_BUNDLE COOKIES GSSAPI_${${SSL_DEFAULT} == base :?BASE :NONE} DICT FTP GOPHER HTTP HTTP2 IMAP NTLM OPENSSL POP3 PROXY RESOLV RTSP SMTP TELNET TFTP THREADED_RESOLVER TLS_SRP > > Did you forget to bump PORTREVISION when changing default options? > The thinking was that: NTLM is (was) an implicit default because OPENSSL is an OPTIONS_DEFAULT, and that this fixed a build failure when OpenSSL was built without DES (a default option), that it wasn't necessary. Said another way, that it wasn't necessary because it was a noop except for ports users with the build failure Happy to bump the portrev if there's a case for it though