From owner-cvs-sys Mon Oct 27 10:19:15 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id KAA11707 for cvs-sys-outgoing; Mon, 27 Oct 1997 10:19:15 -0800 (PST) (envelope-from owner-cvs-sys) Received: from critter.freebsd.dk (critter.freebsd.dk [195.8.129.26]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id KAA11697; Mon, 27 Oct 1997 10:19:02 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost.cybercity.dk [127.0.0.1]) by critter.freebsd.dk (8.8.7/8.8.7) with ESMTP id TAA01417; Mon, 27 Oct 1997 19:18:09 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Bruce Evans cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/isofs/cd9660 cd9660_vnops.c In-reply-to: Your message of "Mon, 27 Oct 1997 06:55:51 PST." <199710271455.GAA09623@freefall.freebsd.org> Date: Mon, 27 Oct 1997 19:18:09 +0100 Message-ID: <1415.877976289@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk cd9660 suffers badly from being cloned from UFS in many other ways too. Great stuff to work on for people who want to learn about filesystems: you cannot corrupt your media and you have a working reference to compare against. In message <199710271455.GAA09623@freefall.freebsd.org>, Bruce Evans writes: >bde 1997/10/27 06:55:50 PST > > Modified files: > sys/isofs/cd9660 cd9660_vnops.c > Log: > Use bread() instead of cluster_read() for reading the last block > in a file. There was a (harmless, I think) off-by-1 error. This > was fixed in ufs long ago (rev.1.21 of ufs_readwrite.c) but not > in cd9660. > > cd9660_read() has stagnated in many other ways. It is closer to > the Net/2 ufs_read() (which is was cloned from) than ufs_read() > itself is. > > Revision Changes Path > 1.49 +2 -2 src/sys/isofs/cd9660/cd9660_vnops.c -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop."