From owner-freebsd-net@FreeBSD.ORG Sat Oct 4 05:02:08 2014 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C1B6DBC2 for ; Sat, 4 Oct 2014 05:02:08 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9027BE5A for ; Sat, 4 Oct 2014 05:02:08 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s9452863009698 for ; Sat, 4 Oct 2014 05:02:08 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 193053] ixgbe(4) IXGBE_LEGACY_TX + ALTQ path broken Date: Sat, 04 Oct 2014 05:02:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 9.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dan_256@yahoo.com X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Oct 2014 05:02:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193053 --- Comment #12 from Dan --- (In reply to ncrogers from comment #11) > (In reply to Dan from comment #10) > > On 10.1-RC1, with the change below, I still get the dreaded "pfctl: igb1: > > driver does not support altq". If ixgbe is targeted for 10.1-RELEASE, can > > igb be fixed as well? > > > > Index: sys/modules/igb/Makefile > > =================================================================== > > --- sys/modules/igb/Makefile (revision 272488) > > +++ sys/modules/igb/Makefile (working copy) > > @@ -21,7 +21,7 @@ > > # instead use the older if_start non-multiqueue capable interface. > > # This might be desireable for testing, or to enable the use of > > # ALTQ. > > -#CFLAGS += -DIGB_LEGACY_TX > > +CFLAGS += -DIGB_LEGACY_TX > > > > .if !defined(KERNBUILDDIR) > > .if ${MK_INET_SUPPORT} != "no" > > > > I posted more about it here: > > > > https://forums.freebsd.org/viewtopic.php?f=44&t=48283 > > I've always had to add #define IXGBE_LEGACY_TX to sys/dev/e1000/if_igb.c and > sys/dev/e1000/if_igb.h to get it to work. Uncommenting CFLAGS in the igb > Makefile doesn't work when compiling a kernel. I believe it needs to be > added as a kernel option of some kind to be cleaner. I guess in the last 3 years, no one has bother to do it because they keep secretly hoping we can stop using legacy mode to use ALTQ :) Pretty sure it would be easy to add as a kernel option. I even saw a thread where someone described what it would take. I wonder why it never got committed. -- You are receiving this mail because: You are the assignee for the bug.