From owner-svn-src-stable-12@freebsd.org Thu May 21 22:45:14 2020 Return-Path: Delivered-To: svn-src-stable-12@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 42FC62F77DC; Thu, 21 May 2020 22:45:14 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mail.bsd4all.net (mail.bsd4all.net [94.130.200.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.bsd4all.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49Sl7Y6Bc5z4SNc; Thu, 21 May 2020 22:45:13 +0000 (UTC) (envelope-from herbert@gojira.at) Date: Fri, 22 May 2020 00:45:03 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gojira.at; s=mail202005; t=1590101105; bh=3vaAlI/8XTo6dyosB+S/bMjhumBfGo2VEsZofyo0L1Y=; h=Date:Message-ID:From:To:Cc:Subject:MIME-Version:Content-Type; b=BNmZh21wYy4/P1nxO7Gl6hr/bFxY9eJ1NvyVo+v2Ik/ljmkvCvgyZKZfyXsd9QyvK eWE1Xfq9QgqCepw+ZPm18NDOVkL4D2JQ11Xi/jUuFMnttTIdG1MqUnOM/j+0hqCEHj Ml57/Fo+d6x5L2Iif6XWsaafAxKW28NC45WXbcUfGTsTHGmbg08rdPaoEQ4/PGn985 XIdeXWgDgAIAnsDBSQ/gwYZAXQptJ2m9zSjCQJdTBCAYBWn9t1rGAalbYtwzVCbYHK Iz1Wj0zuXxPkBJQYah42bI1IBhpFEDdyH70eRQFD0mXBT7iq31F+QFFtP7kaXSgQJv 8Id/Fc/fVpBKA== Message-ID: <87a720aowg.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r361334 - in stable/12/sys: amd64/amd64 arm64/arm64 dev/acpica i386/i386 x86/acpica In-Reply-To: <202005211528.04LFSZFF068443@repo.freebsd.org> References: <202005211528.04LFSZFF068443@repo.freebsd.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/28.0 Mule/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 49Sl7Y6Bc5z4SNc X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:94.130.0.0/16, country:DE] X-BeenThere: svn-src-stable-12@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for only the 12-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2020 22:45:14 -0000 On Thu, 21 May 2020 17:28:35 +0200, Mark Johnston wrote: > > Author: markj > Date: Thu May 21 15:28:35 2020 > New Revision: 361334 > URL: https://svnweb.freebsd.org/changeset/base/361334 > > Log: > MFC r361033: > Call acpi_pxm_set_proximity_info() slightly earlier on x86. > > Modified: > stable/12/sys/amd64/amd64/mp_machdep.c > stable/12/sys/arm64/arm64/mp_machdep.c > stable/12/sys/dev/acpica/acpi_pxm.c > stable/12/sys/dev/acpica/acpivar.h > stable/12/sys/i386/i386/mp_machdep.c > stable/12/sys/x86/acpica/srat.c > Directory Properties: > stable/12/ (props changed) > > Modified: stable/12/sys/amd64/amd64/mp_machdep.c > ============================================================================== > --- stable/12/sys/amd64/amd64/mp_machdep.c Thu May 21 15:18:59 2020 (r361333) > +++ stable/12/sys/amd64/amd64/mp_machdep.c Thu May 21 15:28:35 2020 (r361334) > @@ -265,8 +265,9 @@ cpu_mp_start(void) > init_ops.start_all_aps(); > > set_interrupt_apic_ids(); > -} > > + acpi_pxm_set_cpu_locality(); > +} > > /* > * AP CPU's call this to initialize themselves. Until now it was possible to build a kernel (amd64) without 'device acpi'. After this commit it fails with this error: --- kernel.full --- linking kernel.full ld: error: undefined symbol: acpi_pxm_set_cpu_locality >>> referenced by mp_machdep.c:269 (/usr/src/sys/amd64/amd64/mp_machdep.c:269) >>> mp_machdep.o:(cpu_mp_start) *** [kernel.full] Error code 1 Was that intended? -- Herbert