From owner-freebsd-current@FreeBSD.ORG Sun Jul 20 08:09:55 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A656137B425 for ; Sun, 20 Jul 2003 08:09:55 -0700 (PDT) Received: from milla.ask33.net (milla.ask33.net [217.197.166.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0150243FA3 for ; Sun, 20 Jul 2003 08:09:55 -0700 (PDT) (envelope-from nick@milla.ask33.net) Received: by milla.ask33.net (Postfix, from userid 1001) id C3C863ABB4C; Sun, 20 Jul 2003 17:10:03 +0200 (CEST) Date: Sun, 20 Jul 2003 17:10:03 +0200 From: Pawel Jakub Dawidek To: Divacky Roman Message-ID: <20030720151003.GH437@garage.freebsd.pl> References: <20030720130221.GA39671@stud.fit.vutbr.cz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="dCSxeJc5W8HZXZrD" Content-Disposition: inline In-Reply-To: <20030720130221.GA39671@stud.fit.vutbr.cz> X-PGP-Key-URL: http://garage.freebsd.pl/jules.asc X-OS: FreeBSD 4.8-RELEASE i386 X-URL: http://garage.freebsd.pl User-Agent: Mutt/1.5.1i cc: freebsd-current@freebsd.org Subject: Re: possible unionfs bug X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 15:09:56 -0000 --dCSxeJc5W8HZXZrD Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 20, 2003 at 03:02:21PM +0200, Divacky Roman wrote: +> I might be wrong but this: +>=20 +> free(mp->mnt_data, M_UNIONFSMNT); /* XXX */ +> mp->mnt_data =3D 0; +> =09 +> seems to me wrong.... and might cause crashes etc. +> am I correct or wrong? Could you describe scenario when this could be dangerous? Or why do you think it is? This memory is allocated while mounting unionfs file system, so it is quite natural to free this memory while unmounting file system. --=20 Pawel Jakub Dawidek pawel@dawidek.net UNIX Systems Programmer/Administrator http://garage.freebsd.pl Am I Evil? Yes, I Am! http://cerber.sourceforge.net --dCSxeJc5W8HZXZrD Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iQCVAwUBPxqwyz/PhmMH/Mf1AQEYFwQAgB2Y6VJdgMWjN496a8c0rlDINiZyHU/B m55ZEMOCxWUR607h4YYWvFiGTKT2VOhkDO0O+00hVbUldpG2OhOtvfQBr0N6wzvC ESRVMTgZuTN4+PgP6THRxp4d4S6H/c0vOqlitxs5WNqkg2LgzYES5QuoROiqyOtv +k+4sVuAHx0= =39OX -----END PGP SIGNATURE----- --dCSxeJc5W8HZXZrD--