From owner-freebsd-ports@freebsd.org Sat Jul 16 01:56:07 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1DE1CB9A195 for ; Sat, 16 Jul 2016 01:56:07 +0000 (UTC) (envelope-from euan@potensol.com) Received: from smtp.potensol.com (smtp.potensol.com [103.15.233.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.potensol.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D36711C50; Sat, 16 Jul 2016 01:56:06 +0000 (UTC) (envelope-from euan@potensol.com) Received: from smtp.potensol.com (smtp.potensol.com [103.15.233.195]) by smtp.potensol.com (Postfix) with ESMTP id 0961C44710; Sat, 16 Jul 2016 01:56:03 +0000 (UTC) Received: from webmail.potensol.com (webmail.potensol.com [192.168.10.5]) by smtp.potensol.com (Postfix) with ESMTP id 0A8894470F; Sat, 16 Jul 2016 01:56:01 +0000 (UTC) content-type: text/plain; charset="utf-8" in-reply-to: <201607151610.u6FGAE5N037400@gw.catspoiler.org> from: "Euan Thoms" X-Forward: 192.168.10.5 date: Sat, 16 Jul 2016 09:56:01 +0800 cc: koobs@FreeBSD.org, martin@waschbuesch.de, freebsd-ports@freebsd.org, w.schwarzenfeld@utanet.at to: "Don Lewis" MIME-Version: 1.0 message-id: <7c85-57899400-13-6b8b4580@130330830> subject: =?utf-8?q?Re=3A?==?utf-8?q?_devel=2Fsope=3A?= make =?utf-8?q?=28stage-qa=29?= now fails with =?utf-8?q?DEVELOPER=3Dyes?= complaining about iconv dependency User-Agent: SOGoMail 2.3.13 content-transfer-encoding: quoted-printable X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jul 2016 01:56:07 -0000 On Saturday, July 16, 2016 00:10 SGT, Don Lewis = wrote: > On 15 Jul, Euan Thoms wrote: > > > > On Friday, July 15, 2016 15:26 SGT, Kubilay Kocak > > wrote: > > > >> On 15/07/2016 5:17 PM, Martin Waschb=C3=BCsch wrote: > >> > > >> >> Am 14.07.2016 um 23:29 schrieb Euan Thoms : = > >> >> > >> >> > >> >> On Friday, July 15, 2016 01:11 SGT, Walter Schwarzenfeld > >> >> wrote: > >> >> > >> >>> I think this statements should be only warnings. Cause not all= > >> >>> of these statements are right and each maintianer should decid= e > >> >>> which "USES" or "LIB=5FDEPENDS" are necessairely and which not= . > >> >> > >> >> Well, I don't know enough to comment about whether it should be= > >> >> classed as a warning or an error. But there's definetely a bug = in > >> >> the ports Mk system, since adding USES+=3Diconv does not remove= the > >> >> error. I don't think I even need iconv as a dependency, it shou= ld > >> >> be included lower down in the dependency tree. > >> > > >> > I am not sure about this. At the very least, sope-core does use = > >> > iconv in its NGExtensions (e.g. NSString+Encoding.m). Can we rea= lly > >> > assume some lower dependency package already pulls iconv in? > >> > >> If something in a port links to libiconv (or anything else), then = > >> the dependency should be registered in that port > >> > > > > OK, thanks guys. I will add libiconv as a LIB=5FDEPENDS. But I stil= l > > think there may be a bug. The make error tells me to use USES+=3Dic= onv > > and it doesn't work, I still get the same error about libiconv not = > > being specified as a dependancy. > > It looks like USES=3Diconv doesn't add the dependency on newer FreeBS= D > versions that have basic iconv support in the base system. If you se= t > USES=3Diconv:wchar=5Ft or USES=3Diconv:translit, then it will uncondi= tionally > add the dependency. > > If you don't use the WCHAR=5FT or //TRANSLIT extensions, it may not b= e > necessary to link with -liconv, but it is possible that the port does= > this automatically if it finds that libiconv is installed by another = > dependency. > It seems adding "libiconv.so:converters/libiconv" to LIB=5FDEPENDS clea= rs all errors and warnings. This is what I will use unless anyone can t= ell me why it's not recommended. Thanks everyone involved, for your help. -- Regards, Euan Thoms