From owner-cvs-all  Tue May 22  8:12:54 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5933137B422; Tue, 22 May 2001 08:12:47 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id BAA31136;
	Wed, 23 May 2001 01:12:40 +1000
Date: Wed, 23 May 2001 01:11:12 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Ruslan Ermilov <ru@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/kdump mkioctls
In-Reply-To: <20010522150815.A99517@sunbay.com>
Message-ID: <Pine.BSF.4.21.0105230100540.60933-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Tue, 22 May 2001, Ruslan Ermilov wrote:

> On Tue, May 22, 2001 at 09:38:12PM +1000, Bruce Evans wrote:
> > On Mon, 21 May 2001, Ruslan Ermilov wrote:
> > 
> > > On Mon, May 21, 2001 at 10:06:27AM -0700, Ruslan Ermilov wrote:
> > > > ru          2001/05/21 10:06:27 PDT
> > > > 
> > > >   Modified files:
> > > >     usr.bin/kdump        mkioctls 
> > > >   Log:
> > > >   Work around the side effect of src/include/Makefile,v 1.137 changes.
> > > >   (The proper fix is to add missing #include directives.)
> > > >   
> > > ... and to install missing headers to /usr/include.
> > 
> > Actually, the proper fix is to implement headers properly, so that no
> > #include directives are missing.
> > 
> You mean, each header should include all required headers except probably
> a few special like <sys/types.h> etc?

Headers should include all the required headers and shall not have any
namespace pollution.  Usually, only special headers can be included to
satisfy the first requirement, since including general ones with break
the second requirement.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message