From owner-cvs-src@FreeBSD.ORG  Mon Aug 16 13:59:39 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3F10216A4E6
	for <cvs-src@FreeBSD.org>; Mon, 16 Aug 2004 13:59:38 +0000 (GMT)
Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B2CF843D5E
	for <cvs-src@FreeBSD.org>; Mon, 16 Aug 2004 13:59:38 +0000 (GMT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 30076 invoked from network); 16 Aug 2004 13:59:38 -0000
Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx)
	([216.27.160.63])          (envelope-sender <jhb@FreeBSD.org>)
	encrypted SMTP
	for <cvs-all@FreeBSD.org>; 16 Aug 2004 13:59:36 -0000
Received: from slimer.baldwin.cx (slimer.baldwin.cx [192.168.0.16])
	(authenticated bits=0)
	by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i7GDxUJG030165;
	Mon, 16 Aug 2004 09:59:33 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
From: John Baldwin <jhb@FreeBSD.org>
To: "David E. O'Brien" <obrien@FreeBSD.org>
Date: Mon, 16 Aug 2004 09:55:23 -0400
User-Agent: KMail/1.6.2
References: <200408160828.i7G8SwGn067849@repoman.freebsd.org>
	<200408160937.43004.jhb@FreeBSD.org>
In-Reply-To: <200408160937.43004.jhb@FreeBSD.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200408160955.23819.jhb@FreeBSD.org>
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/release Makefile
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Aug 2004 13:59:40 -0000

On Monday 16 August 2004 09:37 am, John Baldwin wrote:
> On Monday 16 August 2004 04:28 am, David E. O'Brien wrote:
> > obrien      2004-08-16 08:28:58 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     release              Makefile
> >   Log:
> >   Accept the fact that floppies either aren't applicable or relevant on
> > most platforms.  So make the floppy logic easier to read.
>
> Please revert this unreviewed commit.  I like to build releases at work
> with 'NO_FLOPPIES=yes' on i386 just so I can skip the extra time spent
> building floppies when I only do installs over FTP and CD-ROM.  Changing
> the sense of the knob breaks that feature.  This also has basically zero
> impact as far as readability.

Well, I see you did fix this eventually but it sure would be nice if you would 
get gratuitous code churn reviewed first.

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org