From nobody Fri Nov 10 07:30:33 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SRVpx2K36z50gj2 for ; Fri, 10 Nov 2023 07:30:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SRVpx0RHFz4c8Q for ; Fri, 10 Nov 2023 07:30:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699601433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VAYXRXBqBhcjKPaypFnjDDTaUzGjJCkdowMKGU2cQSE=; b=BlAnwCFMdyMfRCQp56j3lZz8nMiSBbzUNUTSSZAkKazjboxB37j2ifpvyE3ug5kT1Hti9r Tubssx/U/KJ/krvjjlgHMLFUUT6zOFZOCXsjxeDhh7dZ6ks3uJ9WSwQoeMmCnzhBFO/EiB nlXr5zBP6K+P3qGnLJil7Cnv25vzL19NKLCXmr2RQSiXxvI7iWx5r1tEF9Hn/L5kwg/qBs RD5B0/lDWIg2gL5qrX764d5enPeCDjxqZ4Zld12qdsOzZQ3na+5YpSG1NQjoYYIRrX5LH0 OEsOjnlpyyOUitQWjWfxZ6yNILhKxXiHeII4dFNerhu6E4YvgCK/Nz8wFAQqeQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699601433; a=rsa-sha256; cv=none; b=JPN739Di3CrF+g51KGWfGXtKFgADha9C0DJvEF0onUk41b9goMJ+DY8BsgsfscL8pN2fxi TiZC4VUsIAU/KHDOLgEuLDHCrjMyvoX14axj+Tb0es4YjDEJ5PBLU3avfGJV2+biar1NTM PjsDD5j1K/mWkM/A7VezjgMGPDO1GEhS8aS0vW8uhZoujF+ZgipOQgv72/3PMzCx2Jydoe Jsxs5oYnzumVVPEo1leeTZT+xNNQm1laeJkYVG4x/tScpiLxzC6LFdHf8TMQPaHR+RMLiT EWVrOmbxAJCM2BNj50b0TtZLJwBh3frrRMF3Bms3mPT9y5FKgb64QHFl4pxt0g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SRVpw6CCyzpvZ for ; Fri, 10 Nov 2023 07:30:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3AA7UW0T047344 for ; Fri, 10 Nov 2023 07:30:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3AA7UWSr047343 for bugs@FreeBSD.org; Fri, 10 Nov 2023 07:30:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 275006] libpfctl: c2e7cbe0edb backport broke label set on rule Date: Fri, 10 Nov 2023 07:30:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: franco@opnsense.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275006 Bug ID: 275006 Summary: libpfctl: c2e7cbe0edb backport broke label set on rule Product: Base System Version: 13.2-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: franco@opnsense.org Created attachment 246228 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D246228&action= =3Dedit fix the typo Hi, If you compare the change from from main and stable/13 you can see that main uses "nvl" and stable/13 has "nlvr" for nvlist_append_string_array() but the backport changes it to "nlv". I'm not even sure if this was a clean cherry-pick or manual conflict resolution, but it isn't working in either c= ase. This code was supposed to apply to pfctl_add_eth_rule() but instead applied= to pfctl_add_rule() for otherwise interesting reasons. Since pfctl_add_eth_ru= le() uses "nvl" and pfctl_add_rule() uses "nvlr" but also has "nvl" this compiled fine but still broke the label set. The bit that is most intriguing is that pfctl_add_eth_rule() doesn't even e= xist on stable/13 and that this wasn't caught by the existing tests. A patch is attached. Cheers, Franco --=20 You are receiving this mail because: You are the assignee for the bug.=