From owner-freebsd-current@FreeBSD.ORG Fri Aug 1 22:42:31 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3A8C7B69 for ; Fri, 1 Aug 2014 22:42:31 +0000 (UTC) Received: from mail-qa0-x22b.google.com (mail-qa0-x22b.google.com [IPv6:2607:f8b0:400d:c00::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F039A223B for ; Fri, 1 Aug 2014 22:42:30 +0000 (UTC) Received: by mail-qa0-f43.google.com with SMTP id w8so4588433qac.16 for ; Fri, 01 Aug 2014 15:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=AWb3quM70LSiq/wkYz7p8zGsQGE0fgm5IKHqhGuWXUg=; b=u3wUk4woSNS93JdKCrvjbb90IWPkQcaN5/vEeb/y4l7bzGJ1+utpQQhDKBlm8iT7M8 ydnUAYy5p1Bf9NPT7hzlk0WwIOZEAqrYwYne0/yM3rSSpslRYxejYV58QZTLVqGiQIjA k1qbCiRr3JZNIscjpy8KAbnmzcdnDGFbdAmYtwbFgA6dEDOb59Iki2YKZ/++O+AXiK/b xNDBR05vcV0w7dFdNCukM7gGDNHfHi3gYqRzFTz/5Kel1/RHys+WmXlga2MdCndKII0B yZabI5UDg4rJLo/3u6s8yS1veIHjY11vheN9AN3PdWZ8UtY8hG/g/kFvIF5ft147B56p O6Ow== MIME-Version: 1.0 X-Received: by 10.224.171.197 with SMTP id i5mr14513778qaz.55.1406932950062; Fri, 01 Aug 2014 15:42:30 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.1.6 with HTTP; Fri, 1 Aug 2014 15:42:30 -0700 (PDT) In-Reply-To: <20140801222118.GH50495@funkthat.com> References: <20140801193403.GE50495@funkthat.com> <20140801222118.GH50495@funkthat.com> Date: Fri, 1 Aug 2014 15:42:30 -0700 X-Google-Sender-Auth: 4p-aCfwmaDETk6lW-QhQIC4fHWs Message-ID: Subject: Re: domain_add(xxx) after domainfinalize... From: Adrian Chadd To: Svatopluk Kraus , freebsd-current Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2014 22:42:31 -0000 I'd just make it a panic. :) -a On 1 August 2014 15:21, John-Mark Gurney wrote: > Svatopluk Kraus wrote this message on Sat, Aug 02, 2014 at 00:05 +0200: >> Just what I've got in January 2011: >> http://lists.freebsd.org/pipermail/freebsd-hackers/2011-January/034037.html > > Sadly, after three (or six+) years, it is clear that these bugs will > not be fixed, and this warning message is not useful, since no one has > stepped up to fix them.. > > btw, you might want to create a bug w/ the information you tracked down > to hopefully help the person that decides to finally fix them, though > I doubt they will ever be fixed as people apparently don't see bad > behavior... > > Unless someone fixes the bugs in the next few days, I will commit the > following patch: > Index: uipc_domain.c > =================================================================== > --- uipc_domain.c (revision 266964) > +++ uipc_domain.c (working copy) > @@ -227,15 +227,10 @@ > printf("WARNING: attempt to domain_add(%s) before " > "domaininit()\n", dp->dom_name); > #endif > -#ifdef notyet > - KASSERT(domain_init_status < 2, > - ("attempt to domain_add(%s) after domainfinalize()", > - dp->dom_name)); > -#else > - if (domain_init_status >= 2) > - printf("WARNING: attempt to domain_add(%s) after " > - "domainfinalize()\n", dp->dom_name); > -#endif > + /* > + * XXX - there are bugs WRT to adding domain after domain_finalize is > + * called > + */ > mtx_unlock(&dom_mtx); > } > > >> On Fri, Aug 1, 2014 at 9:34 PM, John-Mark Gurney wrote: >> >> > So, I have a laptop that devd loads the bluetooth module every time.. >> > >> > This means I get the following error on every boot: >> > WARNING: attempt to domain_add(bluetooth) after domainfinalize() >> > WARNING: attempt to domain_add(netgraph) after domainfinalize() >> > >> > Is there any real benefit to this warning? I just looked at the code, >> > and the domain gets added despite the warning... >> > >> > Also, it looks like the pervious warning, we should just make that an >> > if/panic since it's clearly a programming bug, or kill the ifndef >> > INVARIANTS... > > -- > John-Mark Gurney Voice: +1 415 225 5579 > > "All that I will do, has been done, All that I have, has not." > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"