From owner-cvs-ports@FreeBSD.ORG Sun May 17 06:52:13 2009 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 369D21065670; Sun, 17 May 2009 06:52:13 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: from mail-ew0-f159.google.com (mail-ew0-f159.google.com [209.85.219.159]) by mx1.freebsd.org (Postfix) with ESMTP id 9D67D8FC13; Sun, 17 May 2009 06:52:11 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: by ewy3 with SMTP id 3so3226240ewy.43 for ; Sat, 16 May 2009 23:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=zOmpSGYWxPwZS6z3KtHslD6SPP9rp0v6UToawsvRwy0=; b=XrsUIvHCSiP7u2ouxFcqqmr+gVpt4fIa99fOE+mnTwQGkgMlFoliiTPxDgebTGy3W8 Rh/P6k/YJieG81wrU386lanRrPznrD+SKQk7sEZh1Rm6YjoUycSGNw9EiyvqhFaJvKjT MGDUDtR7dGh5gRyKZx8egOKS8ozYrYifXd/Qk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=iXkO8NPat6mdljybiv+tby4iJQl3EOaOjX8K59/1yNFWk8v+WdzK+DhxN61joZSz08 qdiuJ7fmGRxflacgwcfwCcHUvujtHtJ7dAxChg+XyVGqNFOtJUNLfLvUyTd0nI4DmZ8Q Lc+RrP8y8QfMM6Y/kWWZVesFNE7CfKh+ejQQM= MIME-Version: 1.0 Received: by 10.216.48.195 with SMTP id v45mr1732713web.123.1242543130493; Sat, 16 May 2009 23:52:10 -0700 (PDT) In-Reply-To: <20090517084754.5003f6f9@it.buh.tecnik93.com> References: <200905092141.n49LfomV031060@repoman.freebsd.org> <20090510162002.A2CAA8FC4E@release.ixsystems.com> <790a9fff0905101305l70d7809cl1ca2525729d53daa@mail.gmail.com> <4A0F6548.1010205@FreeBSD.org> <20090517084754.5003f6f9@it.buh.tecnik93.com> Date: Sun, 17 May 2009 01:52:10 -0500 Message-ID: <790a9fff0905162352xc2fa29cl9cf411cf9e6b3a22@mail.gmail.com> From: Scot Hetzel To: Ion-Mihai Tetcu Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Doug Barton , QAT@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org, ports@freebsd.org, cvs-ports@freebsd.org, imp@freebsd.org Subject: Re: cvs commit: ports/net Makefile ports/net/bwi-firmware-kmod Makefile distinfo pkg-descr pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 May 2009 06:52:13 -0000 On Sun, May 17, 2009 at 12:47 AM, Ion-Mihai Tetcu wrot= e: > On Sat, 16 May 2009 18:15:52 -0700 > Doug Barton wrote: > >> Scot Hetzel wrote: >> > This shouldn't be flaged as an mtree error. =A0The reason that >> > linker.hints was left behind is due to this file is generated by >> > kldxref. =A0The port/package runs kldxref during the install of the >> > firmware module to update the existing or create a linker.hints >> > file, and when the package is removed, it runs kldxref again to >> > clean up the linker.hints file to only contain the modules >> > in /boot/modules. =A0It has no way to know if it is safe to remove >> > this file. >> >> Would it be safe to remove if it's empty? > > Doh! I don't see why not. :-) > I performed a test where only bwi_v3_ucode.ko was installed into a directory, ran kldxref on the directory and it created a 88 byte linker.hints file. I then removed the kernel module from the directory, ran kldxref. Kldxref removed the empty linker.hints file. So it looks like all kernel module ports should have this code added to their pkg-plists: %%KMODDIR%%/kernel_module.ko @exec kldxref %%KMODDIR%% @unexec kldxref %%KMODDIR%% The bwi-firmware-kmod port had these changes applied on 5/16, and QAT shouldn't be reporting this error any more. Scot