From nobody Tue Mar 3 18:16:59 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQPDQ5Ltyz6TRgr for ; Tue, 03 Mar 2026 18:17:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQPDQ0zthz3QNh for ; Tue, 03 Mar 2026 18:17:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-2ae46b9c70dso11978215ad.1 for ; Tue, 03 Mar 2026 10:17:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772561832; x=1773166632; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=s3nl9oc+Z4Vaj+jGQDZa5B9XqS0NfFtv/spEtCwXDrg=; b=lUwavJWC2WsbW+xFnvMjOImWqUklxPbcrsAEO+UpQDCpAr2zP4cgO15kVypwaxvSIn mlnh8+KaQBO+Qic5ThENhrW13DIJJpr/ND3f0aG93m1XCjgKV3XgVy2+i4u1TorNQBSj M6aMQYQNxG6i2e+5oFLYAGrj8Oq/atejhAJ/DUj7eI/XbqR+yFrugaX7sEluMe2ShLKO ja/yG6KP+FQqJ1aLdxJ0wibTdYoXmw2YMhTbKWaCwpdpDMPuBSs8a3ywHGBR1Oh8+6eb S6cEytB5cSjofGW8wJgbxCibKVS8MICOypx7ZOk6cXxBxZ0t4Pi46WLudf02SWEauKug n2zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772561832; x=1773166632; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s3nl9oc+Z4Vaj+jGQDZa5B9XqS0NfFtv/spEtCwXDrg=; b=Q0T2jAslMirdfYNZMw4byqe1x0BEvQop7tCwWMXMlBdFi/iV/3FKz/zEuxDL7dt3Ne Zj7vp7Gc5Y2iRsOgRXMdlpjKlpu2aAXcZkYjb9gV5f/fMstUiyDXg6hqRqL6OwS8pdC1 vufa25WBNSUCj66jHzP3PKGAK9xhEm99tyMUMg1i0oJKhATJOhxt4dG0S3WGRJEekTZr a/t7zne9bwHmfjkVyzgB4yBZ2pXHCowQ0hHj3oJ4wAbnlm+y2aBlCjDibQE0fmtB5Gds 9uh6u7+fDCR4t9AvuwMWqjRByP6vKSEF9WIMDZFde0/ZC2r+1pqBgdcWkw0MQ5FTLsOc y1Zg== X-Forwarded-Encrypted: i=1; AJvYcCX9Sv0Z2iazlzv8+eeB4n24CfGdMad8SRX7ZUHZvjeZGCZE2tjf2Jr8WF631JhNgqfv+Sr1Q1x5XlrF19D2GArpkBtQ@freebsd.org X-Gm-Message-State: AOJu0Yw4Uqjs3LdyHvHFo5Ub5lDnXDT8LRxbluUjW0wMBxU8TWhg1sL7 iNA3fJRXQEBFcHGQUkWJ5sSaDvwr5DqIDG6gZc+WGRwJL0BNuRhH5kYQ X-Gm-Gg: ATEYQzyxwlczK+Z0qlC1ikZfXmJmoF6HDT+pZBgY/tXayOlqbhpMt8gRJHIL5OY0IdG fe82Oz1gseecSu36NWQzGYDIOdB70OcS/faw/MZIksNsN9zLmlPHKmnuNz+ErTvsLWr3/Nh36pG HcfByYetzXBRqZPJ+sqlsGuB+JMSwPpvbAZn+TRhIa1GWcC/qf9M74QKzRf8SRfaJCzBfqY/8+4 0gWexjIjomIokyyvERqdxvmAReH63jw1JrUXnF3ywKnaZFvo1QPK6mpMpZQvxss7KuBs4AehWvI Qrzy1VE5H+I0Wi06eHqGGDN0ZfNh+FpoqAm0tHDC9xj+/zBVEvrNMuVIf90npaDk+Zs0NtYjljK Gpn9voSuxV3WruPazeasJxaDuBRmLyFRU+JEd0LsbhBQVEQ0DP6SvzuQLIXdLyhCTG6uFDPCKxr d8mNN/7bJlWB87TYRDsewm6cvFHE5gch7gOACbBktcew== X-Received: by 2002:a17:903:1905:b0:2ae:47d7:e101 with SMTP id d9443c01a7336-2ae60c53f62mr27571055ad.1.1772561832017; Tue, 03 Mar 2026 10:17:12 -0800 (PST) Received: from smtpclient.apple ([145.79.197.104]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae4f945985sm101939455ad.71.2026.03.03.10.17.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Mar 2026 10:17:10 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_6A232A0B-4DA2-4CDC-9776-749693A57015"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.3\)) Subject: Re: git: 912864912b71 - main - Run `make obj` before running `make test-includes` From: "Enji Cooper (yaneurabeya)" In-Reply-To: Date: Tue, 3 Mar 2026 10:16:59 -0800 Cc: Brooks Davis , Enji Cooper , src-committers , "" , "" Message-Id: References: <69a678f3.3f811.148b0d7d@gitrepo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3826.700.81.1.3) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4fQPDQ0zthz3QNh X-Spamd-Bar: ---- --Apple-Mail=_6A232A0B-4DA2-4CDC-9776-749693A57015 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 3, 2026, at 4:22=E2=80=AFAM, Warner Losh = wrote: >=20 > On Tue, Mar 3, 2026 at 5:18=E2=80=AFAM Brooks Davis = wrote: > On Tue, Mar 03, 2026 at 04:25:48AM -0700, Warner Losh wrote: > > On Mon, Mar 2, 2026, 11:00???PM Enji Cooper = wrote: > >=20 > > > The branch main has been updated by ngie: > > > > > > URL: > > > = https://cgit.FreeBSD.org/src/commit/?id=3D912864912b71951f9a636190b1dba805= 28f588eb > > > > > > commit 912864912b71951f9a636190b1dba80528f588eb > > > Author: Enji Cooper > > > AuthorDate: 2026-03-03 05:59:50 +0000 > > > Commit: Enji Cooper > > > CommitDate: 2026-03-03 05:59:56 +0000 > > > > > > Run `make obj` before running `make test-includes` > > > > > > Before this change, `make test-includes` (run as part of = buildworld) > > > would place test files in the current directory, which would = clutter up > > > git clones. Run `make obj` beforehand to ensure that the files = are put > > > in `${.OBJDIR}` instead of `${.CURDIR}`. This helps cut down = on the > > > noise significantly when running commands like `git status`. > > > > >=20 > > I've never seen this happen. .OBJDIR is created automatically for me = always > > for the last 5 years... I run buildworld all the time. Can you = explain when > > / how it happens more specifically or back out the change? >=20 > The commit message is unintentionally misleading and incomplete. I = hit > the problem a week or so ago when fixing gcc12 builds and lacked the > time to follow up. test-includes is fine as part of buildworld, but > when run directly from src does fill tools/build/test-includes with .c > files if you blow away the objdir (which seems to the the only = reliably > way to cause test-includes to retest some more complex cases.) >=20 > Ah! That should have been in the commit message as the edge case > that provoked this. That's a decent explanation, though there's other > bits of buildworld that will also cause problems if you do them in = isolation > and not part of buildworld. This one, though, is important enough to = make > an exception for, I think. It's one that's most likely to be used in = isolation. Hi Warner, I consistently run into this behavior when doing mfsbsd builds on my = 14.3-RELEASE host using this src.conf: https://reviews.freebsd.org/P702 = . MK_AUTO_OBJ=3Dyes as shown here: https://reviews.freebsd.org/P703 . I always run this target as part of buildworld on my 14.3-RELEASE host, = so whatever is working on your end is likely an artifact of the build = host environment, whereas what=E2=80=99s not working for me like you = expect is an artifact of my build host environment. This: > Before this change, `make test-includes` (run as part of buildworld) > would place test files in the current directory, which would clutter = up > git clones.=20 Could more accurately be expressed like this: > Before this change, `make test-includes` (run as part of buildworld) > would place test files in the current directory on my 14.3-RELEASE > build host, which would clutter up git clones.=20 The exact reason why there=E2=80=99s a difference eludes me right now. -Enji PS I was waiting for a response to the Differential for over a week; I = landed the change because I hadn=E2=80=99t received feedback on the = review in that period of time and because it gets really old quickly = having to always do `git status -uno` in my clones to make sure I=E2=80=99= m not accidentally committing things that shouldn=E2=80=99t be = committed. This is especially annoying when doing rebases with my = =E2=80=9CMac=E2=80=9D dev branch because it has a lot of overlapping = sections of code in asmc(4) and thunderbolt(4).= --Apple-Mail=_6A232A0B-4DA2-4CDC-9776-749693A57015 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmmnJZsACgkQGpE5DjPs NJirEQ//YJuRxzhrEiJmZE6Oa1OnC+z9d9MKSGL2wxUrHYyKVh6vMTstrHaEG+uS 1R9zrZPPnKK4GazKcKcfA+86iATUwdFl9elQ0TmUPCjvqqdtyN5jYpkwL0h84hJ1 slgo9di4vgYZC7qQdTSWNXZt+wwpYNM+QE9GjTBuyFfgEpFryKMfeNyDLUE7Amgr n9LRbRucZv/kDPA3WrHHpGLyl8oiwgLO7bMyw9ch8ZGJQCQn967iA4Vrj2hjST8+ H2USEt785lOK7I8lQcTCOjvv+oqNUaldf8mtP7lfdWzay21vNajYlrPmx2HFsRwt S3ShoPiOTJmmBxNfcZRVAGiYPfJIli044CM7k+75l/Va9eZBcHa4/wD3EnNHrIDg md0gLbkt/wavf8rNXYJX1cheELYlRODpvrHfpXY+o7B4suGIuAAkRTNKqTKIyAPw WhfjaEcQwmDTKHollNfSpQVf8aQ48b+DQSpnl/HRkAE/T5Koz0Qy0nwxsqEIyf4q +IkqiqrOFGsIvbnSCHdLF+yMudGLYuNtvJIjbR0ZcHR1XPAWprdP9LQQ8JTs/TYz sQvziVHjw0yPwZGbwZtdQaDj4fP5E/yK+q6KdxVD8yayy6Lzj+iL9Zh1EQM2+wXt foetu1s2wPkDWJoBhAUsG5tCSzwrXTr7QbFeGa929KKQAxUmLN0= =7t/q -----END PGP SIGNATURE----- --Apple-Mail=_6A232A0B-4DA2-4CDC-9776-749693A57015--