Date: Wed, 21 Apr 2021 17:23:16 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 255309] ice(4) driver doesn't use RSS option correctly Message-ID: <bug-255309-227@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255309 Bug ID: 255309 Summary: ice(4) driver doesn't use RSS option correctly Product: Base System Version: 12.2-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: brian90013@gmail.com Created attachment 224335 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D224335&action= =3Dedit patch to properly support rss option Hello, I am testing the Intel E810 NIC using the ice driver on both FreeBSD-12.2 a= nd FreeBSD-13.0. During testing, I enabled the RSS kernel configuration option= so the driver would use the system-wide standard RSS key instead of the custom= ice key. I was surprised to see even after rebooting, the driver was still using the ice key. My debugging led me to ice_lib.h where ice_rss.h is included. However, I do= n't believe there is a prior include of ice_opts.h, so when ice_rss.h is parsed, RSS is not defined causing ice-specific definitions to be used. I added ice_opts.h to the include list above ice_rss.h and re-compiled. I hit a second problem within ice_rss.h where ICE_DEFAULT_RSS_HASH_CONFIG is only defined inside the !RSS block. I believe this is an oversight, probably hidden by the previous bug. That variable is used in ice_lib.c so it cannot depend on the state of the RSS option. Therefore, I moved the definition outside of the RSS/!RSS blocks. With these two changes, in the included patch file, I observed the ice driv= er using RSS settings from the kernel, not ice-specific values. Looking at the FreeBSD-13.0 and HEAD branches, it looks like the same problems are present. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255309-227>