From owner-svn-src-all@freebsd.org  Mon Dec  7 19:12:37 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 74D739D205B;
 Mon,  7 Dec 2015 19:12:37 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: from mail-io0-x230.google.com (mail-io0-x230.google.com
 [IPv6:2607:f8b0:4001:c06::230])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 45BF91258;
 Mon,  7 Dec 2015 19:12:37 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: by iofh3 with SMTP id h3so121695iof.3;
 Mon, 07 Dec 2015 11:12:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc:content-type;
 bh=pNx9LmdLu5V2yOEqEuGnqdUnu/T/Uc0JFWGCRqWYFs8=;
 b=u7oD6Y4qwMCbwsFd6ZZZqvxeI7EA/BNUiMjRnvJUnboFblwvzFbM46K1WAhxA8Ez32
 sBIMTm5HtTZCIirA64Kwj0D0eVJmTuZGPGxPyZlQ84ZnEhc7HYGPug/Y6YFu4lG6bYMb
 x+6udw+91U9XU8j1WkqAK0a6vS26rrhPTNBw4FSVeuPM0vFFB8CfsnhZ+ACzOQWYBDbO
 LfJQ7p7yp2JUmm5nlZL31eY5Q+X8IKSqQchvGbQ4KWXHYeQ8r9yyvBxUyoAqmpBPYVnI
 60CQxTRSPmFXAyrPUJyOcMQX9ReRTxxlh1VZNC34Q/3T/bL0ste5RfIrh8c3xc9sgUQt
 TOEg==
X-Received: by 10.107.159.199 with SMTP id i190mr25245460ioe.29.1449515556735; 
 Mon, 07 Dec 2015 11:12:36 -0800 (PST)
MIME-Version: 1.0
Sender: carpeddiem@gmail.com
Received: by 10.107.169.85 with HTTP; Mon, 7 Dec 2015 11:12:17 -0800 (PST)
In-Reply-To: <5FA6DD6B-C70B-4E5A-BD04-5897B02E5FC8@gmail.com>
References: <201512071024.tB7AOcjr094296@repo.freebsd.org>
 <1449512013.1358.6.camel@freebsd.org>
 <5FA6DD6B-C70B-4E5A-BD04-5897B02E5FC8@gmail.com>
From: Ed Maste <emaste@freebsd.org>
Date: Mon, 7 Dec 2015 14:12:17 -0500
X-Google-Sender-Auth: SM_RKjMYEQXy6CA7QhGmNl6Kayc
Message-ID: <CAPyFy2D-qMiSEZ3WA09rVcxC4QW42qWmV+EshcOOCFr=46hmKQ@mail.gmail.com>
Subject: Re: svn commit: r291929 - head/tools/tools/nanobsd
To: Garrett Cooper <yaneurabeya@gmail.com>
Cc: Ian Lepore <ian@freebsd.org>, Warner Losh <imp@freebsd.org>, 
 "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Dec 2015 19:12:37 -0000

On 7 December 2015 at 14:07, Garrett Cooper <yaneurabeya@gmail.com> wrote:
>
> Warner's commit was good. There's a more bulletproof way to do this to make it more portable (in most cases, not all), but it would be overkill:
>
> [ "x$x" != x ]

That construct is to support ancient shells that haven't been relevant
for a very long time. It's not necessary today and only serves to
confuse the reader.