From owner-cvs-src@FreeBSD.ORG Tue Sep 2 09:19:54 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D88E61065694 for ; Tue, 2 Sep 2008 09:19:54 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.152]) by mx1.freebsd.org (Postfix) with ESMTP id 5DF628FC21 for ; Tue, 2 Sep 2008 09:19:54 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by fg-out-1718.google.com with SMTP id l26so1465552fgb.35 for ; Tue, 02 Sep 2008 02:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=W5q/I0Q+s3/KHZ5E7fWOZ/OeU7nm1pXyu/JX8KDMaOQ=; b=kUIqTi5tuCebkGENhrUiR3hvs2hRwnLV+a+O5a+0aAsDfE6p13IX2A8nrgNrx4eIne INRA4Z/+pwMQ3v8nkD3iaJlH/lVFhMXe7yJAIQHGE1EZBZwnzBlSbu3V3UYohsjbnAls 6a2eAsHe30dRNTj9HeB8bRaQgMlbKge7DHi2c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=BMOg1hzNWD5DRAAOApR9br4mGQArKZxgrJ38lD8oPWH3vOgMgckh8k7PTsCIhMETsJ +Yc0+hCpItkbuOSku22NvmOsJGofBieqUTkUd5qdWylMQcz3X8cyI/RidvPMKnB+Udvx UiN+QewzhUqLn6WSQI1CHjgoIoBJXMVgo22W4= Received: by 10.86.60.15 with SMTP id i15mr5422391fga.14.1220347192518; Tue, 02 Sep 2008 02:19:52 -0700 (PDT) Received: by 10.86.2.18 with HTTP; Tue, 2 Sep 2008 02:19:52 -0700 (PDT) Message-ID: <3bbf2fe10809020219s3c63d387y31bd43e33c0b9c33@mail.gmail.com> Date: Tue, 2 Sep 2008 11:19:52 +0200 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Robert Watson" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200808281530.m7SFU3h7013986@repoman.freebsd.org> <1220333613.6499.5.camel@localhost> X-Google-Sender-Auth: 7f2ff198383f90cd Cc: Vladimir Grebenschikov , cvs-src@freebsd.org, src-committers@freebsd.org, amistry@am-productions.biz, cvs-all@freebsd.org Subject: Re: cvs commit: VOP_ATTRIB ... and sysutils/fusefs-kmod X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2008 09:19:54 -0000 2008/9/2, Robert Watson : > > On Tue, 2 Sep 2008, Vladimir Grebenschikov wrote: > > > > On Thu, 2008-08-28 at 15:23 +0000, Attilio Rao wrote: > > > > > attilio 2008-08-28 15:23:18 UTC > > > > > > > This patch makes CURRENT with Gnome badly crash (just crash while starting > Gnome). > > > > I've found that it is due to ABI change, and tried to rebuild fusefs-kmod > - it just fails due to changed interface. > > > > Patch below fixes problem for me. (but I still does not completely sure > about td = curthread) > > > > Please fix fusefs-kmod port also. > > > > Side question, is there any way to prevent loading of kmod's with broken > ABI ? > > > > 8-CURRENT kernels should reject old modules from loading unless > __FreeBSD_version hasn't been bumped. And indeed, it looks like this change > did not come with a __FreeBSD_version bump, which it should have as a > non-trivial change to the kernel KPI and KBI. As this is not a sole change (and it is a part of a bigger plan) I intended to do a __FreeBSD_version bump just once all the changes are in place. I came to this after past experience to do 1:1 modify for __FreeBSD_version and KPI, which was adding too much overhead for what it was needed. If we still think a 1:1 __FreeBSD_version bumping is the right thing to do, I can establish again this in new VFS commit though. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein