From owner-svn-src-head@freebsd.org Tue Mar 15 16:48:23 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5574BAD2348; Tue, 15 Mar 2016 16:48:23 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1F174173E; Tue, 15 Mar 2016 16:48:23 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x229.google.com with SMTP id g203so31196311iof.2; Tue, 15 Mar 2016 09:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=Xk7KXUQ5eJoAgLbEMKHmadnelLQHVkHqmIf+55UkJIA=; b=cwoSE8KgaU5ET5RDsNsVZ26IwyMMEz41EWPOO5FPQ3CwNBmQspdtqxcTM8MlwOdr9c Jhq6Y8qRh1VMpG8tSA/HhuD+gwmptSX2MUf3gKaqwHFM7YzkzdQnKFe+iawxOZYOXhMu EZ+52lmM04uDcjqo2XCPohxjcdS+mQb3EH9ccjTyJtpdKaibYwwam5cytASiYrpvL238 t8h0XN/FaI9L4+poaju5Z3Ivvtiv3PQhSgcRrkVRpg8sgHM1WSrBduRLfZcVkdhuMIiE 6uwR29Z619tR6uLsquOdxMu8uyt6gnCXsCo5E1793k8nhH5f3i0lX3SrmDcDoRGIzoi0 vd0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=Xk7KXUQ5eJoAgLbEMKHmadnelLQHVkHqmIf+55UkJIA=; b=Fr/195vSVIWpVJKTqwoLrKv4/i7ojVZIU3dtkzIf/Ps2h/+lp/xvnzjwmfDgUhRM65 +tiadb1svawBTChYsic2tUPYyMP2r1jIMtfvjFfA4zWaYaQduXBN1VE3Y5yr3pZL6zci HRv+1fHNJnSMyy6gx1TPPpHq4s0mwGRQjAPFj4bD1H0v3BI8Xovcg0swX8MwNWcwJ4ZX eA4S+OpyWmv44k7YWDzvwTQbiH0b9wqghKZAzsXC0NpVuGlGCVgwvEDE276FYZWbLFOg mkW+k+TkpdOf2fAIIj+qoXmNCSNBFBNrGIkVEhSK33qRndnEswBDVzGN7UBib+jR74VV VWyw== X-Gm-Message-State: AD7BkJJLSUPc4h7HSywE2aehTPfq1OdX5o9bBpJb3TIuUy6gDNEiMpZVcgWEvWLfyuZqhRm1yPLfqJuec1CDog== MIME-Version: 1.0 X-Received: by 10.107.162.144 with SMTP id l138mr29420463ioe.123.1458060502435; Tue, 15 Mar 2016 09:48:22 -0700 (PDT) Received: by 10.36.14.19 with HTTP; Tue, 15 Mar 2016 09:48:22 -0700 (PDT) In-Reply-To: <201603151553.u2FFrbZG081474@repo.freebsd.org> References: <201603151553.u2FFrbZG081474@repo.freebsd.org> Date: Tue, 15 Mar 2016 09:48:22 -0700 Message-ID: Subject: Re: svn commit: r296910 - head/sys/ofed/drivers/net/mlx4 From: Adrian Chadd To: Hans Petter Selasky Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2016 16:48:23 -0000 hiya, make sure you set M_HASHTYPE_ appropriately? -adrian On 15 March 2016 at 08:53, Hans Petter Selasky wrote: > Author: hselasky > Date: Tue Mar 15 15:53:37 2016 > New Revision: 296910 > URL: https://svnweb.freebsd.org/changeset/base/296910 > > Log: > Use hardware computed Toeplitz hash for incoming flowids > > Use the Toeplitz hash value as source for the flowid. This makes the > hash value more suitable for so-called hash bucket algorithms which > are used in the FreeBSD's TCP/IP stack when RSS is enabled. > > Sponsored by: Mellanox Technologies > MFC after: 1 week > > Modified: > head/sys/ofed/drivers/net/mlx4/en_rx.c > head/sys/ofed/drivers/net/mlx4/en_tx.c > > Modified: head/sys/ofed/drivers/net/mlx4/en_rx.c > ============================================================================== > --- head/sys/ofed/drivers/net/mlx4/en_rx.c Tue Mar 15 15:47:26 2016 (r296909) > +++ head/sys/ofed/drivers/net/mlx4/en_rx.c Tue Mar 15 15:53:37 2016 (r296910) > @@ -616,7 +616,8 @@ int mlx4_en_process_rx_cq(struct net_dev > goto next; > } > > - mb->m_pkthdr.flowid = cq->ring; > + /* forward Toeplitz compatible hash value */ > + mb->m_pkthdr.flowid = be32_to_cpu(cqe->immed_rss_invalid); > M_HASHTYPE_SET(mb, M_HASHTYPE_OPAQUE); > mb->m_pkthdr.rcvif = dev; > if (be32_to_cpu(cqe->vlan_my_qpn) & > > Modified: head/sys/ofed/drivers/net/mlx4/en_tx.c > ============================================================================== > --- head/sys/ofed/drivers/net/mlx4/en_tx.c Tue Mar 15 15:47:26 2016 (r296909) > +++ head/sys/ofed/drivers/net/mlx4/en_tx.c Tue Mar 15 15:53:37 2016 (r296910) > @@ -1060,7 +1060,7 @@ mlx4_en_transmit(struct ifnet *dev, stru > > /* Compute which queue to use */ > if (M_HASHTYPE_GET(m) != M_HASHTYPE_NONE) { > - i = m->m_pkthdr.flowid % priv->tx_ring_num; > + i = (m->m_pkthdr.flowid % 128) % priv->tx_ring_num; > } > else { > i = mlx4_en_select_queue(dev, m); >