From owner-freebsd-bugs@FreeBSD.ORG  Mon Oct  3 10:20:28 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D21A316A41F
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  3 Oct 2005 10:20:28 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9E1C543D46
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  3 Oct 2005 10:20:28 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j93AKSOg062626
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 3 Oct 2005 10:20:28 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j93AKSg9062625;
	Mon, 3 Oct 2005 10:20:28 GMT (envelope-from gnats)
Date: Mon, 3 Oct 2005 10:20:28 GMT
Message-Id: <200510031020.j93AKSg9062625@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Yar Tikhiy <yar@comp.chem.msu.su>
Cc: 
Subject: Re: kern/86618: [if_nge] [panic] panic with ifconfig nge
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Yar Tikhiy <yar@comp.chem.msu.su>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Oct 2005 10:20:28 -0000

The following reply was made to PR kern/86618; it has been noted by GNATS.

From: Yar Tikhiy <yar@comp.chem.msu.su>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: kern/86618: [if_nge] [panic] panic with ifconfig nge
Date: Mon, 3 Oct 2005 14:13:26 +0400

 For the record: here is a detailed explanation of the problem from Yuriy.
 
 ----- Forwarded message from "Yuriy N. Shkandybin" <jura@networks.ru> -----
 
 From: "Yuriy N. Shkandybin" <jura@networks.ru>
 To: Yar Tikhiy <yar@FreeBSD.org>
 Subject: Re: kern/83011: nge vlans broken
 Date: Mon, 3 Oct 2005 14:06:45 +0400
 
 Absolutely!
 There is nge_stop() call from nge_init_locked()
 it's might be noticed from traces i've provided.
 Also i suppose problem appears due static nge nge_rx_list and nge_tx_list 
 allocation in struct nge_list_data
 This leads to trash appeares here and when
 for (i = 0; i < NGE_RX_LIST_CNT; i++) {
                if (sc->nge_ldata->nge_rx_list[i].nge_mbuf != NULL) {
                        m_freem(sc->nge_ldata->nge_rx_list[i].nge_mbuf);
                        sc->nge_ldata->nge_rx_list[i].nge_mbuf = NULL;
                }
        }
 
 performed 
 wrong sc->nge_ldata->nge_rx_list[i].nge_mbuf    appeares and this leads to 
 crash.
 
 Jura
 
 
 
 >On Mon, Oct 03, 2005 at 06:50:18AM +0000, Yuriy N. Shkandybin wrote:
 >>
 >> Sure i've tested and it's definitely fixed.
 >
 >Thanks!
 >
 >> I've got another bug with this driver
 >> See PR 86618
 >
 >Alas, I have no nge(4) hardware, so I posted a message
 >to freebsd-net asking people to review PR 86618.  The
 >problem description looks nearly correct to me though.
 >The only odd point I noticed was that nge_stop was called
 >in responce to "ifconfig nge0 up" command.  Are you sure
 >it wasn't "ifconfig nge0 down"?
 >
 >-- 
 >Yar
 >
 
 ----- End forwarded message -----
 
 -- 
 Yar