From owner-freebsd-net@freebsd.org  Mon Feb 25 09:29:00 2019
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21B93150348B
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Mon, 25 Feb 2019 09:29:00 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [88.99.82.50])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 948C083E36
 for <freebsd-net@freebsd.org>; Mon, 25 Feb 2019 09:28:58 +0000 (UTC)
 (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [176.74.212.121])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 078A726012D;
 Mon, 25 Feb 2019 10:28:49 +0100 (CET)
Subject: Re: Infiniband: Mellanox MT26418 in ethernet mode causes crash on
 shutdown
To: Andreas Kempe <kempe@lysator.liu.se>, freebsd-net@freebsd.org,
 freebsd-drivers <freebsd-drivers@mellanox.com>
References: <8763252f-d433-5e1e-9e3b-628e0545c8eb@lysator.liu.se>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <940f6859-037b-68d6-298a-513ea6ebf7ce@selasky.org>
Date: Mon, 25 Feb 2019 10:28:28 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <8763252f-d433-5e1e-9e3b-628e0545c8eb@lysator.liu.se>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 948C083E36
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org;
 spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as
 permitted sender) smtp.mailfrom=hps@selasky.org
X-Spamd-Result: default: False [-6.50 / 15.00]; ARC_NA(0.00)[];
 RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0];
 RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[];
 R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; FROM_HAS_DN(0.00)[];
 MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org];
 NEURAL_HAM_LONG(-1.00)[-1.000,0];
 TO_MATCH_ENVRCPT_SOME(0.00)[];
 MX_GOOD(-0.01)[mail.turbocat.net];
 NEURAL_HAM_SHORT(-0.91)[-0.911,0];
 IP_SCORE(-3.28)[ip: (-9.49), ipnet: 88.99.0.0/16(-4.66), asn: 24940(-2.25),
 country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[];
 R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+];
 ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE];
 MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[];
 RCVD_COUNT_TWO(0.00)[2]
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Feb 2019 09:29:00 -0000

Hi,

Your patch looks good and Mellanox will test it a bit internally before 
pushing upstream.

I think the if_down() call is not strictly needed. ether_ifdetach() 
already does this. Can you test the patch w/o the if_down() call?

--HPS