From owner-freebsd-hackers@FreeBSD.ORG Mon Apr 26 08:10:44 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A8148106564A; Mon, 26 Apr 2010 08:10:44 +0000 (UTC) (envelope-from eitanadlerlist@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.157]) by mx1.freebsd.org (Postfix) with ESMTP id 09EA88FC12; Mon, 26 Apr 2010 08:10:43 +0000 (UTC) Received: by fg-out-1718.google.com with SMTP id 22so1514499fge.13 for ; Mon, 26 Apr 2010 01:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=sbX8Zf0mdje7tH+dIpVhm72YtKdWCMxfyIYxMo64ajM=; b=jcqygMWPNIkO5kzqSnXYSn+2oP/BxKm6Q87NK4YV0vbxDu681Ch1NEzsT+Oghpa3Si P624Ii4AmSzkMMXXi9g/MwNzcbSHsClIfKcGl57pPeK5dElaouyqcGhrZ92IVx6SiZvk 1yNx7GUqiq9e/trsAIxQ2OHAs3N6P0d+XcAWg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=dI3/VsJXBOLoyWzxI70GnudcHW8Uy6HIpQgDWNT3kQfTlG+XwSngXeHPUvL6Cn8IKM +pO4XUroOIvtzlxtKJE83KDaqkSXXJ/3jue+nCpIqV3uLljqjc/26NSX6BLpoCpeThaD XyMGVqka11WuYOzfZPWqS3bNLfFQSgn+SJnfg= Received: by 10.239.180.201 with SMTP id j9mr310462hbg.5.1272269438087; Mon, 26 Apr 2010 01:10:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.239.193.77 with HTTP; Mon, 26 Apr 2010 01:10:18 -0700 (PDT) In-Reply-To: References: <4BCE5ECC.6070202@gmail.com> <4BD07F2D.3030809@FreeBSD.org> <4BD07FCB.4030604@FreeBSD.org> <4BD5009C.20300@FreeBSD.org> From: Eitan Adler Date: Mon, 26 Apr 2010 11:10:18 +0300 Message-ID: To: Garrett Cooper Content-Type: text/plain; charset=UTF-8 Cc: freebsd-hackers@freebsd.org, Ruben de Groot , Doug Barton , "Aryeh M. Friedman" , =?UTF-8?Q?Trond_Endrest=C3=B8l?= Subject: Re: regenerating /var/db/pkg X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2010 08:10:44 -0000 > It would be nice if some of the more usable functions got moved out of > rc.subr though :(... It would cure 20 lines of duplicate code here and > elsewhere outside of rc land... Where should they go? I'll gladly work on a patch to make them available to periodic scripts. > > Yes, and you're assuming that users won't do: > > PKG_DBDIR := /my /super /special/ directory with spaces > > Granted, a lot of things probably won't work that way, but just > compounding to the issue of not quoting variables seems like a silly > mistake to make :/. IMHO a user that uses crazy things should know that things will break Almost no program around correctly handles all filenames: http://www.dwheeler.com/essays/filenames-in-shell.html