From nobody Sun May 3 19:59:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g7wb04kRpz6c0kM for ; Sun, 03 May 2026 19:59:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g7wZz6j3Yz423s for ; Sun, 03 May 2026 19:59:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777838347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KxqC7ry/34V5O7rxAXo3/1pcZiw6o0gGUjzrW0CYBik=; b=WwAQxaGHtpx63Bygk2w+sjO504ZAhYjfEjJ8ccc3g3pg7DRqXJcGwvVYHWxv3VUQOgy1S1 Po2hSG22/ZvX4J7l9QG20VzRiiAereQ/jjUAroz32T31TyaYc80p6UGv0WeKk5TYzOQp4M QSYfRCL/iuPnSZfGh5lvfsP+NF2KVmQjHBEtPDT7xXLABDpWLvwlu1DyB9C7BAg6DncjI9 j9JhPhhckyCMiiEXGd0S4cSEbbAItXmPVmtLD602yVmE2Pm2wu8SLGDN78wkVXNImhC8CC dQ/sd3+koq7o+TY7a1CqNnsAMBkbau2wmOpJ52f3RpEois8g7T3uGXYo2aBP1Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777838347; a=rsa-sha256; cv=none; b=yUA7YwuBUaz+ClU+PvEr24iNKrh6wiHYmi7ovyAt9tKKjzZH75qbF4bx4f0iTf3ISwd6A/ qNgvPrlSPpOIEY9OM5F6CcR3ulM1O/dbiJO2ebt+UAbALW4/THdrUyXV9ZiauIK/44rTyE CK3cay7p412UhmSo+2xq4nfpYxfAHVXwBvkwMsCsYP3sDDG/i7ZMc0ON1SAOcp/d9bAhAH Mujw6A6+wJStneyjqO7gFPVG86+CQUlOeY1eWUhBA6lxLaMhoqKY5geh7haGUsLz2fEz27 NvkwtwgS6VYSpJ9r4CHsZ/fyVW7hconTPdlCcigjWIx3pvmuRhL7HPxX43Is4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777838347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KxqC7ry/34V5O7rxAXo3/1pcZiw6o0gGUjzrW0CYBik=; b=c/a92Qjgnl/p0n9k/a2WNaUt0Hy6GFa69kCMW8l7F1oMdWSVPRzyZDF0HyyUh5vCByyZgG Zrla+L2ULo9jne/QJOfjgV4MtgBX/OUXo5k53EpoG7N7bHriPBLT94rgTdSWUCbYViPa4i 1RLV/shOIto/8/t3hqglvXLv4NzUEky/Sgf1gZyGHqKs0u2WaSGkyJaky0zbYPY+b1Gqfr ujKc52gPYIgzRUjrNpqC3PWu9D1edNfch8O3OjIeS6+piArNmYvngdasvBSXFU4GiGDUQd BhzOXc0ANVxc/L5i122HWwm0WjV65kiQsHNgoMRAwlFB4ZDgRkcrGpZNZa8jlA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g7wZz6HHfznK1 for ; Sun, 03 May 2026 19:59:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 406c0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 03 May 2026 19:59:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: fbecfc4aa028 - main - fdescfs: do not change vnode type on VOP_GETATTR() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fbecfc4aa028964f972a0457809aa041d415f61b Auto-Submitted: auto-generated Date: Sun, 03 May 2026 19:59:02 +0000 Message-Id: <69f7a906.406c0.5bb26524@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=fbecfc4aa028964f972a0457809aa041d415f61b commit fbecfc4aa028964f972a0457809aa041d415f61b Author: Konstantin Belousov AuthorDate: 2026-05-03 19:09:15 +0000 Commit: Konstantin Belousov CommitDate: 2026-05-03 19:58:36 +0000 fdescfs: do not change vnode type on VOP_GETATTR() There is no point to do it. The VNON type is good enough for fdescfs operations, and changing the type on stat(2) is arbitrary and does not serve much purpose, because we recalculate the returned file type on each stat(2) anyway. But setting the type to VLNK has undesired consequence of namei() trying VOP_READLINK() there, which might fail since it defer the calculation of path to vn_fullpath(). Submitted by: Mike PR: 294768 MFC after: 2 weeks --- sys/fs/fdescfs/fdesc_vnops.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/fs/fdescfs/fdesc_vnops.c b/sys/fs/fdescfs/fdesc_vnops.c index c1188c3819e7..267e80918d1b 100644 --- a/sys/fs/fdescfs/fdesc_vnops.c +++ b/sys/fs/fdescfs/fdesc_vnops.c @@ -469,7 +469,6 @@ fdesc_getattr(struct vop_getattr_args *ap) break; } - vp->v_type = vap->va_type; return (0); }